Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 137dd5475825f8297c708d4d310c823ba4bcfc22
https://github.com/WebKit/WebKit/commit/137dd5475825f8297c708d4d310c823ba4bcfc22
Author: Ryosuke Niwa <[email protected]>
Date: 2026-10-07 (Wed, 07 Oct 2026)
Changed paths:
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
M Tools/WebKitTestRunner/ios/TestControllerIOS.mm
Log Message:
-----------
[Site Isolation] [iOS] Force US English QWERTY keyboard
https://bugs.webkit.org/show_bug.cgi?id=326539
Reviewed by Rupin Mittal and Wenson Hsieh.
http/tests/site-isolation/key-events.html and
http/tests/site-isolation/type-in-cross-origin-iframe.html
intermittently fail on iOS because the synthesized key events produce Cyrillic
characters
(e.g. "x" becomes "ч" and "hello" becomes "руддщ").
iOS tests synthesize hardware key events by HID usage, so the resulting
characters depend on
the current keyboard layout. We only restored the keyboard input mode when a
test explicitly
overrode it via setKeyboardInputModeIdentifier, so a change made by UIKit
itself, which is
persisted in the simulator's keyboard preferences, leaked into subsequent tests.
Fixed the bug by restoring the US English QWERTY input mode with the US
hardware layout
between tests whenever the current input mode differs from it.
* Tools/TestRunnerShared/spi/UIKitSPIForTesting.h:
* Tools/WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
Canonical link: https://commits.webkit.org/322973@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
