Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: df034aab4454c55d0a0993a483b76ada1b6bc487
https://github.com/WebKit/WebKit/commit/df034aab4454c55d0a0993a483b76ada1b6bc487
Author: Ryosuke Niwa <[email protected]>
Date: 2026-10-07 (Wed, 07 Oct 2026)
Changed paths:
M LayoutTests/platform/ios-site-isolation/TestExpectations
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
Log Message:
-----------
[Site Isolation]
http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html
times out
https://bugs.webkit.org/show_bug.cgi?id=326679
Reviewed by Alex Christensen.
The test times out because WebKitTestRunner's InjectedBundlePage keeps waiting
on a frame whose
provisional load has moved to another process. The iframe first loads a
same-site URL, so its
provisional load starts in the main frame's process and becomes
m_topLoadingFrame. The server then
redirects to a cross-site URL, and the load continues in another process. In
that case, FrameLoader
does not dispatch didFailProvisionalLoad in the original process, and
didFinishLoad is dispatched in
the new process, so m_topLoadingFrame is never cleared. notifyDone() therefore
always returns early.
Fixed the bug by clearing m_topLoadingFrame in notifyDone() once the frame is
no longer loading in
this process. At that point the frame's state is either FrameState::Complete or
it has become
a RemoteFrame; both are reported as kWKFrameLoadStateFinished.
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::notifyDone):
Canonical link: https://commits.webkit.org/323010@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
