Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 269fd7f808be78f090785aa40fae751c2b6b7a80
https://github.com/WebKit/WebKit/commit/269fd7f808be78f090785aa40fae751c2b6b7a80
Author: Alan Baradlay <[email protected]>
Date: 2026-10-07 (Wed, 07 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
M Source/WebCore/rendering/BaselineAlignment.cpp
M Source/WebCore/rendering/BaselineAlignment.h
M Source/WebCore/rendering/GridBaselineAlignment.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderGrid.cpp
Log Message:
-----------
[cleanup] Remove the redundant LineDirection enum in favor of BoxAxis
https://bugs.webkit.org/show_bug.cgi?id=318068
<rdar://problem/181445301>
Reviewed by Antti Koivisto.
BoxAxis is WebCore's enum for the physical horizontal and vertical axes,
already used by
RenderBox::containingBlockRangeForPositioned() and the flex formatting code.
LineDirection was a second enum with the same two values, parked in
RenderBoxModelObject.h under
a stale "line-related functions" comment, and its only remaining use is telling
BaselineAlignment::synthesizedBaseline() which way the lines run.
Pass a BoxAxis named lineDirection instead and remove LineDirection.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::FlexFormattingUtils::marginBoxAscentForFlexItem const):
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::FlexLayout::lastLineBaseline const):
* Source/WebCore/rendering/BaselineAlignment.cpp:
(WebCore::BaselineAlignment::synthesizedBaseline):
* Source/WebCore/rendering/BaselineAlignment.h:
* Source/WebCore/rendering/GridBaselineAlignment.cpp:
(WebCore::GridBaselineAlignment::ascentForGridItem const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::lastLineBaseline const):
Canonical link: https://commits.webkit.org/323015@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
