Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9f3335cd521af07a41b23a23d958d09b26533654
https://github.com/WebKit/WebKit/commit/9f3335cd521af07a41b23a23d958d09b26533654
Author: Elliott Williams <[email protected]>
Date: 2026-10-07 (Wed, 07 Oct 2026)
Changed paths:
M Tools/Scripts/libraries/webkitbugspy/setup.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py
M
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py
Log Message:
-----------
[webkitbugspy] Fix latent bugs found by static analysis
https://bugs.webkit.org/show_bug.cgi?id=326407
Reviewed by Jonathan Bedard.
Running mypy over webkitbugspy, in preparation for adding type annotations,
surfaces several bugs in error paths and rarely used code:
- radar.Tracker.clone referenced an undefined `member` (copied from populate),
so cloning without radarclient raised instead of reporting that radarclient
is inaccessible.
- radar.Tracker.set indexed a dict_keys view when a project has exactly one
component, raising TypeError instead of selecting that component.
- bugzilla.Tracker.projects checked the product-list response's status inside
the per-product loop instead of each product's response, so a failed product
query was parsed rather than skipped.
- mocks.Radar's RadarModel.relationships referenced an undefined `r` when
reporting an unknown relationship type.
Bump webkitbugspy to 0.15.6, which also brings setup.py back in sync with
__init__.py.
* Tools/Scripts/libraries/webkitbugspy/setup.py:
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py:
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.projects):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py:
(RadarModel.relationships):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:
(Tracker.set):
(Tracker.clone):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:
(TestBugzilla.test_projects_failed_product_query):
(TestBugzilla.test_projects_failed_product_query.failing_product_details):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py:
(TestRadar.test_set_component_single_component):
(TestRadar.test_clone_no_radar):
(TestRadar.test_mock_relationships_unknown_type):
Canonical link: https://commits.webkit.org/323039@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
