Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1f1f41afd5eceb63ffb195ea3058e6453944d371
https://github.com/WebKit/WebKit/commit/1f1f41afd5eceb63ffb195ea3058e6453944d371
Author: Fujii Hironori <[email protected]>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/API/glib/InputMethodFilter.cpp
M Source/WebKit/UIProcess/API/glib/InputMethodFilter.h
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestInputMethodContext.cpp
Log Message:
-----------
[GTK][WPE] Input method is not told about caret moves smaller than 10 pixels
https://bugs.webkit.org/show_bug.cgi?id=326778
Reviewed by Carlos Garcia Campos.
InputMethodFilter::notifyCursorRect skipped a cursor area whose location moved
less than 10
pixels from the last one it sent. With a small font, typing a character moves
the caret by less
than that, so the input method was not told. A change in the size of the caret
rect alone was
skipped too. Input methods position candidate windows and on-screen keyboards
from the caret,
and GTK's own GtkText and GtkTextView do not filter either.
Remove the threshold and only skip a cursor area identical to the last one sent.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestInputMethodContext.cpp
* Source/WebKit/UIProcess/API/glib/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::setContext):
(WebKit::InputMethodFilter::notifyFocusedOut):
(WebKit::InputMethodFilter::notifyCursorRect):
* Source/WebKit/UIProcess/API/glib/InputMethodFilter.h:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/glib/TestInputMethodContext.cpp:
(testWebKitInputMethodContextCursorArea):
Canonical link: https://commits.webkit.org/323083@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
