Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 60b2353eafe48874ef6c3805ae24e21f07e5ab4f
https://github.com/WebKit/WebKit/commit/60b2353eafe48874ef6c3805ae24e21f07e5ab4f
Author: Said Abou-Hallawa <[email protected]>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContext.cpp
Log Message:
-----------
Followup(323123@main): Possible crash when drawing a badge SystemImage
https://bugs.webkit.org/show_bug.cgi?id=326833
rdar://189532409
Reviewed by Mike Wyrzykowski.
This change adds the new function RemoteGraphicsContext::drawBadgeSystemImage().
This function checks first whether imageIdentifier is not std::nullopt. If it is
not std::nullopt it gets the NativeImage from the cache. If it is null, it keeps
the local variable nativeImage uninitialized.
The problem is in the call to ARKitBadgeSystemImage::create(). We pass to it
`nativeImage.releaseNonNull()`. This will crash if the nativeImage is null.
The fix is to pass WTF::move(nativeImage).
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContext.cpp:
(WebKit::RemoteGraphicsContext::drawBadgeSystemImage):
Canonical link: https://commits.webkit.org/323145@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
