Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7dfcda9d52dc1ea7c26f537aea4f4c9ac6eb41be
https://github.com/WebKit/WebKit/commit/7dfcda9d52dc1ea7c26f537aea4f4c9ac6eb41be
Author: Antti Koivisto <[email protected]>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/css/CSSAttrValue.cpp
R Source/WebCore/css/CSSAttrValue.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValueData.h
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Content.cpp
M Source/WebCore/css/parser/CSSSubstitutionParser.cpp
M Source/WebCore/css/values/content/CSSContent.cpp
M Source/WebCore/css/values/content/CSSContent.h
M Source/WebCore/editing/cocoa/NodeHTMLConverter.mm
M Source/WebCore/style/MatchedDeclarationsCache.cpp
M Source/WebCore/style/values/content/StyleContent.cpp
Log Message:
-----------
[css-values-5 attr()] Remove the legacy attr() path
https://bugs.webkit.org/show_bug.cgi?id=326821
rdar://problem/189523320
Reviewed by Sam Weinig.
The setting is stable and enabled by default. Remove it along with the legacy
content: attr()
implementation that was only used when it was disabled.
Also remove CSSAttrValue, which has been unused since
https://commits.webkit.org/313849@main.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSAttrValue.cpp: Removed.
* Source/WebCore/css/CSSAttrValue.h: Removed.
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isAttrValue const): Deleted.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp:
(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType const):
(WebCore::DeprecatedCSSOMPrimitiveValue::getStringValue const):
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValueData.h:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Content.cpp:
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedContent):
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedContentLegacyAttrFunction):
Deleted.
* Source/WebCore/css/parser/CSSSubstitutionParser.cpp:
(WebCore::classifyBlock):
* Source/WebCore/css/values/content/CSSContent.cpp:
* Source/WebCore/css/values/content/CSSContent.h:
* Source/WebCore/editing/cocoa/NodeHTMLConverter.mm:
(stringFromCSSValue):
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::isCacheable):
Only the legacy path set hasAttrContent on the parent style. The substitution
path sets it on the style itself.
* Source/WebCore/style/values/content/StyleContent.cpp:
(WebCore::Style::ToStyle<CSS::Content::Data>::operator()):
Canonical link: https://commits.webkit.org/323139@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
