Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e8c36a19c9545858d97c6c9661936abf7e2ebacd
https://github.com/WebKit/WebKit/commit/e8c36a19c9545858d97c6c9661936abf7e2ebacd
Author: Brent Fulgham <[email protected]>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
Log Message:
-----------
[Cocoa] Fix JavaScriptCore handling of "CombinedDomains.json" during cmake
builds
https://bugs.webkit.org/show_bug.cgi?id=326751
rdar://189459265
Reviewed by Keith Miller.
The CMake build generated CombinedDomains.json into the derived sources
directory, where nothing outside
JavaScriptCore finds it. Clients above WebKit run the inspector protocol
generator from the framework's
PrivateHeaders, and that generator reads this file, so it had no input when the
framework came from a CMake
build.
Generate the file directly into JavaScriptCore_SCRIPTS_DIR, which is the
framework's PrivateHeaders on Cocoa, and
read it from there when generating the inspector protocol bindings. That needs
no copy step and leaves one
location for the file on every port.
No new tests. This only changes where the CMake build writes a generated file;
checked by regenerating it and the
inspector protocol bindings on macOS, and by a project-wide ninja dry run with
no unresolved dependencies.
* Source/JavaScriptCore/CMakeLists.txt:
Canonical link: https://commits.webkit.org/323155@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
