Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b23cbc369f8499c76c4ca8c437977394b819e58
https://github.com/WebKit/WebKit/commit/5b23cbc369f8499c76c4ca8c437977394b819e58
Author: Antti Koivisto <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M LayoutTests/svg/hittest/svg-text-vertical-hit-testing.html
M LayoutTests/svg/text/text-anchor-multiple-x-chunks.svg
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/dom/Position.h
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/editing/VisibleUnits.cpp
M Source/WebCore/layout/Verification.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
M Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorBox.h
R Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h
M Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h
M Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.h
M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.h
M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxInlines.h
R Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h
R
Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPathInlines.h
M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h
M Source/WebCore/layout/integration/inline/InlineIteratorSVGTextBox.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorSVGTextBox.h
M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.h
M
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
R Source/WebCore/rendering/BidiRun.cpp
R Source/WebCore/rendering/BidiRun.h
M Source/WebCore/rendering/FloatingObjects.cpp
M Source/WebCore/rendering/GlyphDisplayListCache.cpp
M Source/WebCore/rendering/GlyphDisplayListCache.h
M Source/WebCore/rendering/GlyphDisplayListCacheRemoval.cpp
M Source/WebCore/rendering/GlyphDisplayListCacheRemoval.h
M Source/WebCore/rendering/InlineBoxPainter.cpp
M Source/WebCore/rendering/InlineBoxPainter.h
R Source/WebCore/rendering/LegacyInlineBox.cpp
R Source/WebCore/rendering/LegacyInlineBox.h
R Source/WebCore/rendering/LegacyInlineBoxInlines.h
R Source/WebCore/rendering/LegacyInlineFlowBox.cpp
R Source/WebCore/rendering/LegacyInlineFlowBox.h
R Source/WebCore/rendering/LegacyInlineIterator.cpp
R Source/WebCore/rendering/LegacyInlineIterator.h
R Source/WebCore/rendering/LegacyInlineIteratorInlines.h
R Source/WebCore/rendering/LegacyInlineTextBox.cpp
R Source/WebCore/rendering/LegacyInlineTextBox.h
R Source/WebCore/rendering/LegacyLineLayout.cpp
R Source/WebCore/rendering/LegacyLineLayout.h
R Source/WebCore/rendering/LegacyRootInlineBox.cpp
R Source/WebCore/rendering/LegacyRootInlineBox.h
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderBlockFlowInlines.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderLayerModelObject.cpp
M Source/WebCore/rendering/RenderLayerModelObject.h
R Source/WebCore/rendering/RenderLineBoxList.cpp
R Source/WebCore/rendering/RenderLineBoxList.h
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderOverflow.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderText.h
R Source/WebCore/rendering/RenderTextLineBoxes.cpp
R Source/WebCore/rendering/RenderTextLineBoxes.h
M Source/WebCore/rendering/TextPainter.cpp
R Source/WebCore/rendering/line/BreakingContext.h
R Source/WebCore/rendering/line/LineBreaker.cpp
R Source/WebCore/rendering/line/LineBreaker.h
R Source/WebCore/rendering/line/LineInfo.cpp
R Source/WebCore/rendering/line/LineInfo.h
R Source/WebCore/rendering/line/LineInlineHeaders.h
R Source/WebCore/rendering/line/LineWidth.cpp
R Source/WebCore/rendering/line/LineWidth.h
R Source/WebCore/rendering/line/TrailingObjects.cpp
R Source/WebCore/rendering/line/TrailingObjects.h
M Source/WebCore/rendering/svg/RenderSVGInline.cpp
M Source/WebCore/rendering/svg/RenderSVGInline.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/rendering/svg/RenderSVGInlineText.h
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/RenderSVGText.h
M Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
R Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp
R Source/WebCore/rendering/svg/SVGInlineFlowBox.h
R Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
R Source/WebCore/rendering/svg/SVGInlineTextBox.h
R Source/WebCore/rendering/svg/SVGInlineTextBoxInlines.h
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
R Source/WebCore/rendering/svg/SVGRootInlineBox.cpp
R Source/WebCore/rendering/svg/SVGRootInlineBox.h
M Source/WebCore/rendering/svg/SVGTextBoxPainter.cpp
M Source/WebCore/rendering/svg/SVGTextBoxPainter.h
M Source/WebCore/rendering/svg/SVGTextChunk.cpp
M Source/WebCore/rendering/svg/SVGTextChunk.h
M Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp
M Source/WebCore/rendering/svg/SVGTextChunkBuilder.h
M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp
M Source/WebCore/rendering/svg/SVGTextLayoutEngine.h
M Source/WebCore/rendering/svg/SVGTextQuery.cpp
M Source/WebCore/rendering/svg/SVGTextQuery.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourcePattern.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
M Source/WebKit/WebKitUIProcessPrefix.h
Log Message:
-----------
[IFC] Remove remaining legacy line layout code
https://bugs.webkit.org/show_bug.cgi?id=326945
rdar://189587794
Reviewed by Alan Baradlay.
SVG text was the last remaining client and is now handled by IFC data
structures too. We can remove the code.
This patch removes the legacy inline box tree and code directly interacting
with it. It does not undo all
abstractions or do all the cleanups enabled by this.
The following legacy types are removed:
- LegacyLineLayout
- LegacyInlineBox, LegacyInlineFlowBox, LegacyRootInlineBox, LegacyInlineTextBox
- SVGInlineFlowBox, SVGRootInlineBox, SVGInlineTextBox
- RenderLineBoxList, RenderTextLineBoxes
- LegacyInlineIterator, BidiRun, BidiIsolatedRun, IsolateTracker
- LineBreaker, BreakingContext, LineInfo, LineWidth, TrailingObjects
- InlineIterator::BoxLegacyPath, InlineIterator::LineBoxIteratorLegacyPath
Canonical link: https://commits.webkit.org/323227@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications