Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 14a86e4f1815aea67d1f3177435118d89159c40b
https://github.com/WebKit/WebKit/commit/14a86e4f1815aea67d1f3177435118d89159c40b
Author: Cole Carley <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M Tools/TestWebKitAPI/Helpers/cocoa/FindTestPage.mm
Log Message:
-----------
[Site Isolation] Find in Page API tests no site isolation variants fail on
the site isolation bots
https://bugs.webkit.org/show_bug.cgi?id=326822
rdar://189523615
Reviewed by Ryosuke Niwa.
The site isolation bots run run-api-tests with
--site-isolation-enabled-by-default,
which makes every new WebPreferences start with SiteIsolationEnabled set to
true.
FindTestPage::load only ever turned site isolation on, so SiteIsolation::Off
tests inherited the forced-on value and saw site-isolated behavior. The
cross-origin NoSiteIsolation variants then failed their expectations.
To fix this, I set SiteIsolationEnabled explicitly from the test parameter
before
creating the web view in FindTestPage::load().
* Tools/TestWebKitAPI/Helpers/cocoa/FindTestPage.mm:
(TestWebKitAPI::FindTestPage::load):
Canonical link: https://commits.webkit.org/323192@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
