Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 192bd64a6dcdcb3ab3e70982772afc34171d35e0
https://github.com/WebKit/WebKit/commit/192bd64a6dcdcb3ab3e70982772afc34171d35e0
Author: Sammy Gill <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridItemSizingFunctions.cpp
M Source/WebCore/layout/formattingContexts/grid/GridItemSizingFunctions.h
M Source/WebCore/layout/formattingContexts/grid/GridSizer.cpp
M Source/WebCore/layout/formattingContexts/grid/TrackSizingAlgorithm.h
Log Message:
-----------
[GFC] Represent infinite block space for first column sizing as empty
optional.
https://bugs.webkit.org/show_bug.cgi?id=326900
rdar://189564604
Reviewed by Alan Baradlay.
When sizing columns, the grid area block size an item would have is estimated
by treating rows with a definite max track sizing function as that size and
all other rows as infinite. Infinite rows were represented as LayoutUnit::max(),
so a grid area spanning one saturated to LayoutUnit::max() instead of being
indefinite.
Represent infinite rows, and therefore an indefinite grid area block
size, as std::nullopt so the inline-axis sizing functions can later tell the
two apart when an item's inline size depends on its block size. For
example, when computing the content size suggestion of an item with an
aspect ratio and max-height: 100% we can only use the aspect ratio to
transfer the constraint if the available block axis space is not
infinite.
Canonical link: https://commits.webkit.org/323251@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
