Title: [116054] trunk/Source/_javascript_Core
Revision
116054
Author
oli...@apple.com
Date
2012-05-03 18:05:50 -0700 (Thu, 03 May 2012)

Log Message

Regression(r114702): Clobbering the caller frame register before we've stored it.
https://bugs.webkit.org/show_bug.cgi?id=85564

Reviewed by Filip Pizlo.

Don't use t0 as a temporary, when we're about to use the value in t0.

* llint/LowLevelInterpreter32_64.asm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (116053 => 116054)


--- trunk/Source/_javascript_Core/ChangeLog	2012-05-04 01:00:02 UTC (rev 116053)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-05-04 01:05:50 UTC (rev 116054)
@@ -1,3 +1,14 @@
+2012-05-03  Oliver Hunt  <oli...@apple.com>
+
+        Regression(r114702): Clobbering the caller frame register before we've stored it.
+        https://bugs.webkit.org/show_bug.cgi?id=85564
+
+        Reviewed by Filip Pizlo.
+
+        Don't use t0 as a temporary, when we're about to use the value in t0.
+
+        * llint/LowLevelInterpreter32_64.asm:
+
 2012-05-03  Mark Hahnenberg  <mhahnenb...@apple.com>
 
         Removing remainder of accidental printfs.

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (116053 => 116054)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2012-05-04 01:00:02 UTC (rev 116053)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2012-05-04 01:05:50 UTC (rev 116054)
@@ -1686,8 +1686,8 @@
         addp 16 - 4, sp
         loadp JITStackFrame::globalData + 4[sp], t3
     elsif ARMv7
-        loadp JITStackFrame::globalData[sp], t0
-        storep cfr, JSGlobalData::topCallFrame[t0]
+        loadp JITStackFrame::globalData[sp], t1
+        storep cfr, JSGlobalData::topCallFrame[t1]
         move t0, t2
         preserveReturnAddressAfterCall(t3)
         storep t3, ReturnPC[cfr]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to