Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 830f7786a64c4e45c76442f99ae405da337b04c2
https://github.com/WebKit/WebKit/commit/830f7786a64c4e45c76442f99ae405da337b04c2
Author: Alan Baradlay <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
Log Message:
-----------
[cleanup] Put two flex alignment computations back in their spec steps
https://bugs.webkit.org/show_bug.cgi?id=327105
<rdar://problem/189717013>
Reviewed by Antti Koivisto.
1. Compute each baseline-sharing group member's shouldAdjustTowardsCrossAxisEnd
while aligning the group's baselines,
next to minMarginAfterBaseline, instead of while building the groups; it is
css-align's step 3 fallback alignment.
2. Move the out-of-flow static position's zero-item case from
initialContentAlignmentOffset, which align-content
shares, back into initialJustifyContentOffset, which is what the static
position calls.
3. Add a FIXME: css-flexbox positions the child as if it were the sole flex
item, so space-around and space-evenly
would fall back to safe center when it overflows.
No change in behavior.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::FlexFormattingContext::performBaselineAlignment):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::FlexFormattingUtils::initialJustifyContentOffset):
(WebCore::FlexFormattingUtils::initialContentAlignmentOffset):
Canonical link: https://commits.webkit.org/323358@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
