Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2acc8d01bcdcceffc2ca85ca537f01dc3b118a78
https://github.com/WebKit/WebKit/commit/2acc8d01bcdcceffc2ca85ca537f01dc3b118a78
Author: Anne van Kesteren <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
A
LayoutTests/accessibility/isolated-tree/mac/base-select-picker-option-set-selected-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/base-select-picker-option-set-selected.html
A
LayoutTests/accessibility/isolated-tree/mac/listbox-option-set-selected-expected.txt
A
LayoutTests/accessibility/isolated-tree/mac/listbox-option-set-selected.html
A
LayoutTests/accessibility/mac/base-select-picker-option-set-selected-expected.txt
A LayoutTests/accessibility/mac/base-select-picker-option-set-selected.html
A LayoutTests/accessibility/mac/listbox-option-set-selected-expected.txt
A LayoutTests/accessibility/mac/listbox-option-set-selected.html
M Source/WebCore/accessibility/AccessibilityListBoxOption.cpp
M Source/WebCore/accessibility/AccessibilityListBoxOption.h
M Source/WebCore/accessibility/AccessibilityMenuListOption.cpp
M Source/WebCore/accessibility/AccessibilityMenuListOption.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/html/HTMLOptionElement.cpp
M Source/WebCore/html/HTMLOptionElement.h
Log Message:
-----------
AX: setting AXSelected on an option does not do what the user interface of
the select does
https://bugs.webkit.org/show_bug.cgi?id=327084
rdar://189700978
Reviewed by Tyler Wilcock.
Setting AXSelected on an option should do what non-AX users can do with the
select. Instead, a
base appearance picker ignored it or had its selection replaced, a list box was
focused and clicked
first, and a native dropdown box got no change event.
Add HTMLOptionElement::setSelectedByUser(), which does what the user interface
of the select does,
through pickOrToggleOption() for base appearance and optionSelectedByUser()
otherwise, and ignores
what non-AX users cannot do. AccessibilityNodeObject::setSelected() now calls
it for options.
Tests:
accessibility/isolated-tree/mac/base-select-picker-option-set-selected.html
accessibility/isolated-tree/mac/listbox-option-set-selected.html
accessibility/mac/base-select-picker-option-set-selected.html
accessibility/mac/listbox-option-set-selected.html
Canonical link: https://commits.webkit.org/323366@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
