Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 132c1a571cbe2549aff28a963c0c2502d50ebb92
https://github.com/WebKit/WebKit/commit/132c1a571cbe2549aff28a963c0c2502d50ebb92
Author: Alan Baradlay <[email protected]>
Date: 2026-10-11 (Sun, 11 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
M Source/WebCore/layout/integration/flex/FlexIntegrationUtils.cpp
Log Message:
-----------
[cleanup] Simplify crossAxisDirection, isLeftToRightFlow and
applyStretchedLogicalHeightToFlexItem
https://bugs.webkit.org/show_bug.cgi?id=327096
<rdar://problem/189707612>
Reviewed by Antti Koivisto.
1. Build crossAxisDirection on transformedBlockFlowDirection, which picks the
same block or inline direction, and flip
it only for wrap-reverse instead of testing wrap-reverse in every case.
2. Use !isBlockFlipped() for isLeftToRightFlow's column branch, which compared
the block direction against
top-to-bottom and left-to-right.
3. Merge applyStretchedLogicalHeightToFlexItem's two branches, which differed
only in saving the content logical
height before the stretch layout and restoring it into the cache after.
No change in behavior.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::FlexFormattingUtils::crossAxisDirection const):
(WebCore::FlexFormattingUtils::isLeftToRightFlow const):
* Source/WebCore/layout/integration/flex/FlexIntegrationUtils.cpp:
(WebCore::LayoutIntegration::FlexIntegrationUtils::applyStretchedLogicalHeightToFlexItem):
Canonical link: https://commits.webkit.org/323386@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
