Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 02f33784b29d6d5461fd67ce652b66a2b946004b
https://github.com/WebKit/WebKit/commit/02f33784b29d6d5461fd67ce652b66a2b946004b
Author: Anne van Kesteren <[email protected]>
Date: 2026-10-11 (Sun, 11 Oct 2026)
Changed paths:
M LayoutTests/accessibility/base-select-list-box-content-expected.txt
M LayoutTests/accessibility/base-select-list-box-content.html
M LayoutTests/accessibility/base-select-list-box-expected.txt
M LayoutTests/accessibility/base-select-list-box.html
M
LayoutTests/accessibility/isolated-tree/base-select-list-box-content-expected.txt
M LayoutTests/accessibility/isolated-tree/base-select-list-box-content.html
M LayoutTests/accessibility/isolated-tree/base-select-list-box-expected.txt
M LayoutTests/accessibility/isolated-tree/base-select-list-box.html
A
LayoutTests/accessibility/isolated-tree/mac/select-optgroup-labels-expected.txt
A LayoutTests/accessibility/isolated-tree/mac/select-optgroup-labels.html
A LayoutTests/accessibility/mac/select-optgroup-labels-expected.txt
A LayoutTests/accessibility/mac/select-optgroup-labels.html
M Source/WebCore/accessibility/AccessibilityListBoxOption.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/html/HTMLOptGroupElement.cpp
M Source/WebCore/html/HTMLOptGroupElement.h
Log Message:
-----------
AX: base appearance optgroups are not exposed as they are for native
appearance
https://bugs.webkit.org/show_bug.cgi?id=327134
rdar://189735142
Reviewed by Tyler Wilcock.
A native list box exposes an optgroup as a disabled item with its label, before
its options, and
the native menu of a dropdown box does the same. With base appearance,
322932@main made the
optgroup of a list box an unnamed group that was always disabled and repeated
its label inside,
and a picker left its optgroups out apart from their labels, as unnamed groups.
Expose them as for native appearance. Ignore the optgroup itself, and make what
renders its label,
the label in its user agent shadow tree or its legend, a disabled list box
option, or a menu item
in a picker, with the label of the optgroup and no children. The new
HTMLOptGroupElement::optGroupForLabel() tells which optgroup an element renders
the label of.
Also report an option as disabled when its optgroup is, in any list box, by
using
isDisabledFormControl() rather than only checking the disabled attribute of the
option.
Tests: accessibility/isolated-tree/mac/select-optgroup-labels.html
accessibility/mac/select-optgroup-labels.html
Canonical link: https://commits.webkit.org/323412@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
