Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 69fc55cc38279fc37bcc9b3d1352a10df16b0aa3
https://github.com/WebKit/WebKit/commit/69fc55cc38279fc37bcc9b3d1352a10df16b0aa3
Author: Chris Dumez <[email protected]>
Date: 2026-10-11 (Sun, 11 Oct 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSProperty.h
M Source/WebCore/css/CSSRule.h
M Source/WebCore/css/CSSRuleList.h
M Source/WebCore/css/CSSSelector.h
M Source/WebCore/css/CSSStyleProperties.cpp
M Source/WebCore/css/CSSStyleProperties.h
M Source/WebCore/css/CSSToLengthConversionData.cpp
M Source/WebCore/css/CSSToLengthConversionData.h
M Source/WebCore/css/CSSValueList.h
M Source/WebCore/css/MutableStyleProperties.h
M Source/WebCore/css/SelectorChecker.h
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/css/SelectorFilter.h
M Source/WebCore/css/StyleProperties.h
M Source/WebCore/css/values/CSSValueTypes+DeprecatedCSSOMValueCreation.h
M Source/WebCore/css/values/primitives/CSSPrimitiveData.h
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
Log Message:
-----------
Address Safer C++ warnings in WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=326892
Reviewed by Anne van Kesteren.
Protect call arguments, use CheckedPtr / WeakRef for non-owning data members,
and make them const where possible. Suppress the warnings, with a comment, for
short-lived view structs and for unions whose members are ref-counted manually.
This tested as performance neutral on Speedometer and MotionMark.
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSProperty.h:
(WebCore::CSSProperty::operator== const):
* Source/WebCore/css/CSSRule.h:
* Source/WebCore/css/CSSRuleList.h:
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/CSSStyleProperties.cpp:
(WebCore::StyleRuleCSSStyleProperties::StyleRuleCSSStyleProperties):
(WebCore::StyleRuleCSSStyleProperties::~StyleRuleCSSStyleProperties):
(WebCore::StyleRuleCSSStyleProperties::reattach):
(WebCore::cssParserContextWithMode):
(WebCore::InlineCSSStyleProperties::cssParserContext const):
* Source/WebCore/css/CSSStyleProperties.h:
(WebCore::StyleRuleCSSStylePropertiesOwner::StyleRuleCSSStylePropertiesOwner):
(WebCore::StyleRuleCSSStylePropertiesOwner::setOwnedPropertySet):
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::CSSToLengthConversionData):
* Source/WebCore/css/CSSToLengthConversionData.h:
* Source/WebCore/css/CSSValueList.h:
* Source/WebCore/css/MutableStyleProperties.h:
* Source/WebCore/css/SelectorChecker.h:
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesFullscreenPseudoClass):
(WebCore::matchesInWindowFullscreenPseudoClass):
(WebCore::matchesPictureInPicturePseudoClass):
* Source/WebCore/css/SelectorFilter.h:
* Source/WebCore/css/StyleProperties.h:
* Source/WebCore/css/values/CSSValueTypes+DeprecatedCSSOMValueCreation.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveData.h:
(WebCore::CSS::PrimitiveDataPayload::PrimitiveDataPayload):
(WebCore::CSS::PrimitiveData::PrimitiveData):
(WebCore::CSS::PrimitiveData::asCalc const):
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp:
(WebCore::CSS::PrimitiveDataPayload::unevaluatedCalc const):
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h:
Canonical link: https://commits.webkit.org/323422@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
