Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8270dc47c0f6d441e0bc5b3a9da8121d6c0bca02
https://github.com/WebKit/WebKit/commit/8270dc47c0f6d441e0bc5b3a9da8121d6c0bca02
Author: Ahmad Saleem <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M Source/WebCore/svg/SVGToOTFFontConversion.cpp
Log Message:
-----------
SVGToOTFFontConverter::GlyphData constructor copies its Vector<char>&&
argument instead of moving it
https://bugs.webkit.org/show_bug.cgi?id=327150
rdar://189740254
Reviewed by Chris Dumez.
The GlyphData constructor takes `Vector<char>&& charString` but initialized
its member with `charString(charString)`. Because a named rvalue reference is
an lvalue, this copied the vector instead of moving it, so every glyph paid
for an extra allocation and copy during SVG font conversion. Use WTF::move()
so the buffer is moved.
No new tests, no behavior change.
* Source/WebCore/svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData):
Canonical link: https://commits.webkit.org/323437@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications