Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ade322c8045dce8e930c168c557a6c9efad78403
https://github.com/WebKit/WebKit/commit/ade322c8045dce8e930c168c557a6c9efad78403
Author: Alan Baradlay <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
Log Message:
-----------
[cleanup] Store the flex container's flow-aware border and padding sums in
FlexLayoutConstraints
https://bugs.webkit.org/show_bug.cgi?id=327122
<rdar://problem/189724396>
Reviewed by Antti Koivisto.
1. Carry the container's flow-aware start, end and before border and padding in
FlexLayoutConstraints as three sums,
flowAwareBorderAndPaddingStart, End and Before, instead of separate border
and padding values.
2. Read the sums in computeFlexLineCrossPositions, computeFlexItemRects and
placeFlexItems instead of adding border
and padding at every use; placeFlexItems did it twice per line.
3. Reword the wrap-reverse comment in computeFlexItemRects: the lines are
stacked forwards from the edge that is
css-flexbox's cross-end under wrap-reverse, not its cross-start.
No change in behavior.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::FlexFormattingContext::computeFlexLineCrossPositions):
(WebCore::FlexFormattingContext::computeFlexItemRects):
(WebCore::FlexFormattingContext::placeFlexItems):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::flexLayoutConstraints const):
Canonical link: https://commits.webkit.org/323460@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
