Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ccdaf3ebbe49a9255fe1548e3299e3e57a98ab75
https://github.com/WebKit/WebKit/commit/ccdaf3ebbe49a9255fe1548e3299e3e57a98ab75
Author: Alan Baradlay <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
Log Message:
-----------
[cleanup] Compute the flex container's flow-aware border and padding from its
logical edges
https://bugs.webkit.org/show_bug.cgi?id=327124
<rdar://problem/189724872>
Reviewed by Antti Koivisto.
1. Replace the six physical-side flowAwareBorder and flowAwarePadding helpers
with flowAwareBorderAndPaddingStart, End
and Before, built on borderAndPaddingStart, End, Before and After.
2. Start and End are inline-start and inline-end for a row, swapped for
row-reverse, and block-start and block-end for
a column, including column-reverse, which computeFlexItemRects flips
afterwards.
3. Before is block-start for a row and inline-start for a column, including
wrap-reverse, which computeFlexItemRects
flips afterwards.
4. The logical accessors already include the fieldset legend's intrinsic border
through RenderBlock::borderBefore,
which the physical-side helpers picked up through RenderBlock's
borderTop/Left/Bottom/Right overrides.
No change in behavior.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::FlexFormattingUtils::flowAwareBorderAndPaddingStart const):
(WebCore::FlexFormattingUtils::flowAwareBorderAndPaddingEnd const):
(WebCore::FlexFormattingUtils::flowAwareBorderAndPaddingBefore const):
(WebCore::FlexFormattingUtils::flowAwareBorderStart const): Deleted.
(WebCore::FlexFormattingUtils::flowAwareBorderEnd const): Deleted.
(WebCore::FlexFormattingUtils::flowAwareBorderBefore const): Deleted.
(WebCore::FlexFormattingUtils::flowAwarePaddingStart const): Deleted.
(WebCore::FlexFormattingUtils::flowAwarePaddingEnd const): Deleted.
(WebCore::FlexFormattingUtils::flowAwarePaddingBefore const): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::prepareOutOfFlowBoxForPositionedLayout):
(WebCore::LayoutIntegration::FlexLayout::flexLayoutConstraints const):
Canonical link: https://commits.webkit.org/323467@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
