Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 39703572db489a4376604163ad211e6c9b159c58
https://github.com/WebKit/WebKit/commit/39703572db489a4376604163ad211e6c9b159c58
Author: Antoine Quint <[email protected]>
Date: 2026-10-13 (Tue, 13 Oct 2026)
Changed paths:
A
LayoutTests/webanimations/threaded-animations/transform-individual-properties-expected.txt
A
LayoutTests/webanimations/threaded-animations/transform-individual-properties.html
M Source/WebCore/platform/animation/AcceleratedEffect.cpp
M Source/WebCore/platform/animation/AcceleratedEffectValues.cpp
M Source/WebCore/platform/animation/AcceleratedEffectValues.h
M Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h
M Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h
M Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h
Log Message:
-----------
[threaded-animations] scroll-driven animation draws a `translate` keyframe of
`none` as the element's own `translate`
https://bugs.webkit.org/show_bug.cgi?id=327193
rdar://189882533
Reviewed by Simon Fraser.
If a keyframe held an explicit value of `none` for an individual transform
property (`rotate`, `scale`
and `translate`), then this would be represented as `nullptr` on the
`AcceleratedEffectValues` struct
representing this keyframe's values. This made an implicit and explicit `none`
value indistinguishable.
We now pass a list of explicit properties to the `AcceleratedEffectValues`
constructor and if one of
the individual properties is found, we ensure we create an identity value.
Test: webanimations/threaded-animations/transform-individual-properties.html
*
LayoutTests/webanimations/threaded-animations/transform-individual-properties-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/transform-individual-properties.html:
Added.
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::m_timelineIdentifier):
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/platform/animation/AcceleratedEffectValues.h:
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h:
* Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h:
* Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h:
Canonical link: https://commits.webkit.org/323583@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
