Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3fcb0d2aeca59425ec2e617d1edce9ebc4de25d6
https://github.com/WebKit/WebKit/commit/3fcb0d2aeca59425ec2e617d1edce9ebc4de25d6
Author: Anne van Kesteren <[email protected]>
Date: 2026-10-13 (Tue, 13 Oct 2026)
Changed paths:
M Source/JavaScriptCore/runtime/Error.h
M Source/WebCore/bindings/js/ScriptModuleLoader.cpp
M Source/WebCore/bindings/js/ScriptModuleLoader.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp
Log Message:
-----------
ScriptModuleLoader should hold its ScriptExecutionContext in a CheckedRef
https://bugs.webkit.org/show_bug.cgi?id=327401
rdar://189908965
Reviewed by Ryosuke Niwa.
m_context was weakened from a CheckedRef to a WeakPtr in 263662@main to
accommodate ShadowRealmGlobalScope::moduleLoader(), which built a loader
borrowing another realm's ScriptExecutionContext that could outlive it.
With ShadowRealm removed, every ScriptModuleLoader is owned by its own
ScriptExecutionContext (Document or WorkerOrWorkletGlobalScope) and can no
longer outlive it, so a const CheckedRef is sound again.
Also drop a stale ShadowRealm mention in the createTypeErrorCopy comment;
the function is retained because JSModuleLoader uses it.
Canonical link: https://commits.webkit.org/323692@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
