Title: [116125] trunk/Source/WebCore
- Revision
- 116125
- Author
- [email protected]
- Date
- 2012-05-04 10:47:36 -0700 (Fri, 04 May 2012)
Log Message
Chromium should include MenuListPopups' and MenuListOptions' within the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=85541
Patch by David Tseng <[email protected]> on 2012-05-04
Reviewed by Chris Fleizach.
Covered by existing tests.
LayoutTests/accessibility/menu-list-sends-change-notification.html
* accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::accessibilityIsIgnored):
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116124 => 116125)
--- trunk/Source/WebCore/ChangeLog 2012-05-04 17:44:57 UTC (rev 116124)
+++ trunk/Source/WebCore/ChangeLog 2012-05-04 17:47:36 UTC (rev 116125)
@@ -1,3 +1,18 @@
+2012-05-04 David Tseng <[email protected]>
+
+ Chromium should include MenuListPopups' and MenuListOptions' within the ax tree.
+ https://bugs.webkit.org/show_bug.cgi?id=85541
+
+ Reviewed by Chris Fleizach.
+
+ Covered by existing tests.
+ LayoutTests/accessibility/menu-list-sends-change-notification.html
+
+ * accessibility/AccessibilityMockObject.h:
+ (WebCore::AccessibilityMockObject::accessibilityIsIgnored):
+ * accessibility/chromium/AccessibilityObjectChromium.cpp:
+ (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
2012-05-04 Levi Weintraub <[email protected]>
Unreviewed. Fixing ChangeLog conflict markers after 116009.
Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp (116124 => 116125)
--- trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp 2012-05-04 17:44:57 UTC (rev 116124)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp 2012-05-04 17:47:36 UTC (rev 116125)
@@ -96,6 +96,11 @@
return isEnabled();
}
+bool AccessibilityMenuListOption::accessibilityIsIgnored() const
+{
+ return accessibilityPlatformIncludesObject() != IgnoreObject;
+}
+
LayoutRect AccessibilityMenuListOption::elementRect() const
{
AccessibilityObject* parent = parentObject();
Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h (116124 => 116125)
--- trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h 2012-05-04 17:44:57 UTC (rev 116124)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.h 2012-05-04 17:47:36 UTC (rev 116125)
@@ -37,6 +37,8 @@
public:
static PassRefPtr<AccessibilityMenuListOption> create() { return adoptRef(new AccessibilityMenuListOption); }
+ virtual bool accessibilityIsIgnored() const;
+
void setElement(HTMLElement*);
private:
Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp (116124 => 116125)
--- trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp 2012-05-04 17:44:57 UTC (rev 116124)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp 2012-05-04 17:47:36 UTC (rev 116125)
@@ -62,6 +62,11 @@
return m_parent->isEnabled();
}
+bool AccessibilityMenuListPopup::accessibilityIsIgnored() const
+{
+ return accessibilityPlatformIncludesObject() != IgnoreObject;
+}
+
AccessibilityMenuListOption* AccessibilityMenuListPopup::menuListOptionAccessibilityObject(HTMLElement* element) const
{
if (!element || !element->hasTagName(optionTag))
Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h (116124 => 116125)
--- trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h 2012-05-04 17:44:57 UTC (rev 116124)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h 2012-05-04 17:47:36 UTC (rev 116125)
@@ -41,9 +41,11 @@
virtual bool isEnabled() const;
virtual bool isOffScreen() const;
+ virtual bool accessibilityIsIgnored() const;
void didUpdateActiveOption(int optionIndex);
+
private:
AccessibilityMenuListPopup();
Modified: trunk/Source/WebCore/accessibility/chromium/AccessibilityObjectChromium.cpp (116124 => 116125)
--- trunk/Source/WebCore/accessibility/chromium/AccessibilityObjectChromium.cpp 2012-05-04 17:44:57 UTC (rev 116124)
+++ trunk/Source/WebCore/accessibility/chromium/AccessibilityObjectChromium.cpp 2012-05-04 17:47:36 UTC (rev 116125)
@@ -37,7 +37,7 @@
AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
{
if (isMenuListPopup() || isMenuListOption())
- return IgnoreObject;
+ return IncludeObject;
return DefaultBehavior;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
