Title: [116161] trunk/Tools
- Revision
- 116161
- Author
- [email protected]
- Date
- 2012-05-04 13:46:17 -0700 (Fri, 04 May 2012)
Log Message
Revert to using chromium --test-shell mode on SL in NRWT
https://bugs.webkit.org/show_bug.cgi?id=83076
Unreviewed, build fix.
We seem to be seeing a lot more flakiness on the bot since
I switched NRWT to "DRT" mode. We'll try reverting back and
see if this helps things.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116160 => 116161)
--- trunk/Tools/ChangeLog 2012-05-04 20:28:16 UTC (rev 116160)
+++ trunk/Tools/ChangeLog 2012-05-04 20:46:17 UTC (rev 116161)
@@ -1,3 +1,18 @@
+2012-05-04 Dirk Pranke <[email protected]>
+
+ Revert to using chromium --test-shell mode on SL in NRWT
+
+ https://bugs.webkit.org/show_bug.cgi?id=83076
+
+ Unreviewed, build fix.
+
+ We seem to be seeing a lot more flakiness on the bot since
+ I switched NRWT to "DRT" mode. We'll try reverting back and
+ see if this helps things.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumDriver.__init__):
+
2012-05-04 Christophe Dumez <[email protected]>
[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (116160 => 116161)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-05-04 20:28:16 UTC (rev 116160)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-05-04 20:46:17 UTC (rev 116161)
@@ -413,6 +413,12 @@
self._image_path = None
# FIXME: Delete all of this driver code once we're satisfied that it's not needed any more.
+ if port.host.platform.os_version == 'snowleopard':
+ if not hasattr(port._options, 'additional_drt_flag'):
+ port._options.additional_drt_flag = []
+ if not '--test-shell' in port._options.additional_drt_flag:
+ port._options.additional_drt_flag.append('--test-shell')
+
self._test_shell = '--test-shell' in port.get_option('additional_drt_flag', [])
def _wrapper_options(self, pixel_tests):
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
