Title: [116190] trunk/Source/WebKit/chromium
Revision
116190
Author
[email protected]
Date
2012-05-04 16:42:33 -0700 (Fri, 04 May 2012)

Log Message

[chromium] enable msvs_error_on_missing_sources at gyp time
https://bugs.webkit.org/show_bug.cgi?id=85683

Reviewed by Adam Barth.

This flag checks for missing files, which cause compile times to be
slow on Windows. Since this flag is on by default for the
build.chromium.org bots, we should add it here too so everyone can fix
these errors.

* DEPS: Roll to a chromium version that has no missing files.
* gyp_webkit: Add the flag.

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (116189 => 116190)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-05-04 23:34:25 UTC (rev 116189)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-05-04 23:42:33 UTC (rev 116190)
@@ -1,3 +1,18 @@
+2012-05-04  Tony Chang  <[email protected]>
+
+        [chromium] enable msvs_error_on_missing_sources at gyp time
+        https://bugs.webkit.org/show_bug.cgi?id=85683
+
+        Reviewed by Adam Barth.
+
+        This flag checks for missing files, which cause compile times to be
+        slow on Windows. Since this flag is on by default for the
+        build.chromium.org bots, we should add it here too so everyone can fix
+        these errors.
+
+        * DEPS: Roll to a chromium version that has no missing files.
+        * gyp_webkit: Add the flag.
+
 2012-05-04  Satoru Takabayashi  <[email protected]>
 
         [chromium] Add plumbing for file display names for drag and drop

Modified: trunk/Source/WebKit/chromium/DEPS (116189 => 116190)


--- trunk/Source/WebKit/chromium/DEPS	2012-05-04 23:34:25 UTC (rev 116189)
+++ trunk/Source/WebKit/chromium/DEPS	2012-05-04 23:42:33 UTC (rev 116190)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '134581'
+  'chromium_rev': '135445'
 }
 
 deps = {
@@ -121,6 +121,8 @@
     Var('chromium_svn')+'/ui@'+Var('chromium_rev'), # needed by app
 
   # other third party
+  'third_party/pyftpdlib/src':
+    From('chromium_deps', 'src/third_party/pyftpdlib/src'),
   'third_party/icu':
     From('chromium_deps', 'src/third_party/icu'),
   'third_party/ots':

Modified: trunk/Source/WebKit/chromium/gyp_webkit (116189 => 116190)


--- trunk/Source/WebKit/chromium/gyp_webkit	2012-05-04 23:34:25 UTC (rev 116189)
+++ trunk/Source/WebKit/chromium/gyp_webkit	2012-05-04 23:42:33 UTC (rev 116190)
@@ -119,6 +119,7 @@
                '-Dinside_chromium_build=0',
                '-Dv8_use_snapshot=false',
                '-Dmsvs_use_common_release=0',
+               '-Gmsvs_error_on_missing_sources=1',
 
                # WebKit doesn't use the chromium style checker.
                '-Dmake_clang_dir=Source/WebKit/chromium/third_party/llvm-build/Release+Asserts',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to