Title: [116328] trunk
- Revision
- 116328
- Author
- [email protected]
- Date
- 2012-05-07 11:32:13 -0700 (Mon, 07 May 2012)
Log Message
[GTK] media/video-seek-past-end-playing.html times out
https://bugs.webkit.org/show_bug.cgi?id=84858
Patch by Dominik Röttsches <[email protected]> on 2012-05-07
Reviewed by Philippe Normand.
Source/WebCore:
Removing the intentional state change to PAUSED on didEnd().
My understanding is that the fix works because the additional
state transition to PAUSED was resetting the internal m_seeking state to early,
so that updatePlayState() in HTMLMediaElement was not able to
correctly figure out/recover playstate after seeking.
No new tests, covered by existing media tests, and fixing
video-seek-past-end-playing.html flakiness on GTK, failure on EFL.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
LayoutTests:
video-seek-past-end-playing.html should work reliably after fix, removing.
* platform/gtk/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (116327 => 116328)
--- trunk/LayoutTests/ChangeLog 2012-05-07 18:30:43 UTC (rev 116327)
+++ trunk/LayoutTests/ChangeLog 2012-05-07 18:32:13 UTC (rev 116328)
@@ -1,3 +1,14 @@
+2012-05-07 Dominik Röttsches <[email protected]>
+
+ [GTK] media/video-seek-past-end-playing.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=84858
+
+ Reviewed by Philippe Normand.
+
+ video-seek-past-end-playing.html should work reliably after fix, removing.
+
+ * platform/gtk/test_expectations.txt:
+
2012-05-07 Abhishek Arya <[email protected]>
Crash in RenderBlock::updateFirstLetterStyle.
Modified: trunk/LayoutTests/platform/efl/Skipped (116327 => 116328)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-07 18:30:43 UTC (rev 116327)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-07 18:32:13 UTC (rev 116328)
@@ -1169,7 +1169,6 @@
media/video-reverse-play-duration.html
media/video-seek-by-small-increment.html
media/video-seek-past-end-paused.html
-media/video-seek-past-end-playing.html
media/video-seekable.html
media/video-seeking.html
media/video-set-rate-from-pause.html
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (116327 => 116328)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-07 18:30:43 UTC (rev 116327)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-07 18:32:13 UTC (rev 116328)
@@ -491,7 +491,6 @@
BUGWK84700 : fast/dom/Window/window-postmessage-clone-frames.html = PASS TEXT
BUGWK84856 : media/media-controller-playback.html = PASS TEXT
-BUGWK84858 : media/video-seek-past-end-playing.html = PASS TEXT
// Sometimes asserts in debug builds (cross-platform problem): https://bugs.webkit.org/show_bug.cgi?id=59801
BUGWK84859 : fast/workers/storage/use-same-database-in-page-and-workers.html = PASS TEXT
Modified: trunk/Source/WebCore/ChangeLog (116327 => 116328)
--- trunk/Source/WebCore/ChangeLog 2012-05-07 18:30:43 UTC (rev 116327)
+++ trunk/Source/WebCore/ChangeLog 2012-05-07 18:32:13 UTC (rev 116328)
@@ -1,3 +1,21 @@
+2012-05-07 Dominik Röttsches <[email protected]>
+
+ [GTK] media/video-seek-past-end-playing.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=84858
+
+ Reviewed by Philippe Normand.
+
+ Removing the intentional state change to PAUSED on didEnd().
+ My understanding is that the fix works because the additional
+ state transition to PAUSED was resetting the internal m_seeking state to early,
+ so that updatePlayState() in HTMLMediaElement was not able to
+ correctly figure out/recover playstate after seeking.
+
+ No new tests, covered by existing media tests, and fixing
+ video-seek-past-end-playing.html flakiness on GTK, failure on EFL.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+
2012-05-07 Abhishek Arya <[email protected]>
Crash in RenderBlock::updateFirstLetterStyle.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (116327 => 116328)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2012-05-07 18:30:43 UTC (rev 116327)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2012-05-07 18:32:13 UTC (rev 116328)
@@ -1368,8 +1368,6 @@
m_isEndReached = true;
- gst_element_set_state(m_playBin, GST_STATE_PAUSED);
-
timeChanged();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
