Title: [116394] trunk/Source/WebCore
- Revision
- 116394
- Author
- [email protected]
- Date
- 2012-05-07 22:14:07 -0700 (Mon, 07 May 2012)
Log Message
Fix signed/unsigned mismatch
https://bugs.webkit.org/show_bug.cgi?id=85845
Make literal in assert be unsigned to match comparison on LHS. Avoids
warning on Windows.
Patch by Scott Graham <[email protected]> on 2012-05-07
Reviewed by Eric Seidel.
No new tests. No intended functionality change.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::splitColumn):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116393 => 116394)
--- trunk/Source/WebCore/ChangeLog 2012-05-08 05:00:10 UTC (rev 116393)
+++ trunk/Source/WebCore/ChangeLog 2012-05-08 05:14:07 UTC (rev 116394)
@@ -1,3 +1,18 @@
+2012-05-07 Scott Graham <[email protected]>
+
+ Fix signed/unsigned mismatch
+ https://bugs.webkit.org/show_bug.cgi?id=85845
+
+ Make literal in assert be unsigned to match comparison on LHS. Avoids
+ warning on Windows.
+
+ Reviewed by Eric Seidel.
+
+ No new tests. No intended functionality change.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::splitColumn):
+
2012-05-07 Emil A Eklund <[email protected]>
Fix performance regression for floats caused by LayoutUnit change
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (116393 => 116394)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-05-08 05:00:10 UTC (rev 116393)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-05-08 05:14:07 UTC (rev 116394)
@@ -1294,7 +1294,7 @@
r[pos + 1].cells.append(r[pos].cells);
RenderTableCell* cell = r[pos].primaryCell();
ASSERT(cell);
- ASSERT(cell->colSpan() >= (r[pos].inColSpan ? 1 : 0));
+ ASSERT(cell->colSpan() >= (r[pos].inColSpan ? 1u : 0));
unsigned colleft = cell->colSpan() - r[pos].inColSpan;
if (first > colleft)
r[pos + 1].inColSpan = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
