Title: [116434] trunk/Tools
- Revision
- 116434
- Author
- [email protected]
- Date
- 2012-05-08 10:14:44 -0700 (Tue, 08 May 2012)
Log Message
[GTK] Memory leak in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=85886
Patch by Sudarsana Nagineni <[email protected]> on 2012-05-08
Reviewed by Martin Robinson.
Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
JSString created with JSStringCreateWithUTF8CString.
* DumpRenderTree/gtk/EventSender.cpp:
(gdkModifersFromJSValue):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116433 => 116434)
--- trunk/Tools/ChangeLog 2012-05-08 17:06:11 UTC (rev 116433)
+++ trunk/Tools/ChangeLog 2012-05-08 17:14:44 UTC (rev 116434)
@@ -1,3 +1,16 @@
+2012-05-08 Sudarsana Nagineni <[email protected]>
+
+ [GTK] Memory leak in DRT EventSender.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=85886
+
+ Reviewed by Martin Robinson.
+
+ Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
+ JSString created with JSStringCreateWithUTF8CString.
+
+ * DumpRenderTree/gtk/EventSender.cpp:
+ (gdkModifersFromJSValue):
+
2012-05-08 Christophe Dumez <[email protected]>
[EFL] glib dependency needs to be updated in jhbuild
Modified: trunk/Tools/DumpRenderTree/gtk/EventSender.cpp (116433 => 116434)
--- trunk/Tools/DumpRenderTree/gtk/EventSender.cpp 2012-05-08 17:06:11 UTC (rev 116433)
+++ trunk/Tools/DumpRenderTree/gtk/EventSender.cpp 2012-05-08 17:14:44 UTC (rev 116434)
@@ -298,7 +298,8 @@
return 0;
guint gdkModifiers = 0;
- int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, JSStringCreateWithUTF8CString("length"), 0), 0);
+ JSRetainPtr<JSStringRef> lengthProperty(Adopt, JSStringCreateWithUTF8CString("length"));
+ int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, lengthProperty.get(), 0), 0);
for (int i = 0; i < modifiersCount; ++i)
gdkModifiers |= gdkModifierFromJSValue(context, JSObjectGetPropertyAtIndex(context, modifiersArray, i, 0));
return gdkModifiers;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
