Title: [116496] trunk/Source/WebCore
Revision
116496
Author
[email protected]
Date
2012-05-08 23:14:10 -0700 (Tue, 08 May 2012)

Log Message

Coding style issues present in RenderFrameSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=85955

Reviewed by Eric Seidel.

Just fixed those coding style issues.

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::GridAxis::resize):
(WebCore::RenderFrameSet::layOutAxis):
(WebCore::RenderFrameSet::continueResizing):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (116495 => 116496)


--- trunk/Source/WebCore/ChangeLog	2012-05-09 05:52:38 UTC (rev 116495)
+++ trunk/Source/WebCore/ChangeLog	2012-05-09 06:14:10 UTC (rev 116496)
@@ -1,3 +1,17 @@
+2012-05-08  Mario Sanchez Prada  <[email protected]>
+
+        Coding style issues present in RenderFrameSet.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=85955
+
+        Reviewed by Eric Seidel.
+
+        Just fixed those coding style issues.
+
+        * rendering/RenderFrameSet.cpp:
+        (WebCore::RenderFrameSet::GridAxis::resize):
+        (WebCore::RenderFrameSet::layOutAxis):
+        (WebCore::RenderFrameSet::continueResizing):
+
 2012-05-08  Jon Lee  <[email protected]>
 
         Unreviewed build fix.

Modified: trunk/Source/WebCore/rendering/RenderFrameSet.cpp (116495 => 116496)


--- trunk/Source/WebCore/rendering/RenderFrameSet.cpp	2012-05-09 05:52:38 UTC (rev 116495)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.cpp	2012-05-09 06:14:10 UTC (rev 116496)
@@ -181,9 +181,9 @@
     m_deltas.resize(size);
     m_deltas.fill(0);
     
-    // To track edges for resizability and borders, we need to be (size + 1).  This is because a parent frameset
+    // To track edges for resizability and borders, we need to be (size + 1). This is because a parent frameset
     // may ask us for information about our left/top/right/bottom edges in order to make its own decisions about
-    // what to do.  We are capable of tainting that parent frameset's borders, so we have to cache this info.
+    // what to do. We are capable of tainting that parent frameset's borders, so we have to cache this info.
     m_preventResize.resize(size + 1);
     m_allowBorder.resize(size + 1);
 }
@@ -342,11 +342,10 @@
                 remainingLen -= changePercent;
             }
         }
-    } 
-    
-    // If we don't have any percentage columns/rows we only have fixed columns. Spread
-    // the remainder equally over all fixed columns/rows.
-    else if (remainingLen && countFixed) {
+    } else if (remainingLen && countFixed) {
+        // If we don't have any percentage columns/rows we only have
+        // fixed columns. Spread the remainder equally over all fixed
+        // columns/rows.
         int remainingFixed = remainingLen;
         int changeFixed = 0;
         
@@ -684,7 +683,7 @@
         return;
     int currentSplitPosition = splitPosition(axis, axis.m_splitBeingResized);
     int delta = (position - currentSplitPosition) - axis.m_splitResizeOffset;
-    if (delta == 0)
+    if (!delta)
         return;
     axis.m_deltas[axis.m_splitBeingResized - 1] += delta;
     axis.m_deltas[axis.m_splitBeingResized] -= delta;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to