Title: [116578] trunk/Source/_javascript_Core
- Revision
- 116578
- Author
- [email protected]
- Date
- 2012-05-09 17:04:25 -0700 (Wed, 09 May 2012)
Log Message
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034
Build fix.
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- Eeeep, landed bad version of patch!
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSClassRef.cpp (116577 => 116578)
--- trunk/Source/_javascript_Core/API/JSClassRef.cpp 2012-05-10 00:01:49 UTC (rev 116577)
+++ trunk/Source/_javascript_Core/API/JSClassRef.cpp 2012-05-10 00:04:25 UTC (rev 116578)
@@ -213,7 +213,7 @@
return prototype;
// Recursive, but should be good enough for our purposes
- prototype = JSCallbackObject<JSNonFinalObject>::create(exec, exec->lexicalGlobalObject(), exec->lexicalGlobalObject()->callbackObjectStructure(), prototypeClass, &jsClassData); // set jsClassData as the object's private data, so it can clear our reference on destruction
+ JSObject* prototype = JSCallbackObject<JSNonFinalObject>::create(exec, exec->lexicalGlobalObject(), exec->lexicalGlobalObject()->callbackObjectStructure(), prototypeClass, &jsClassData); // set jsClassData as the object's private data, so it can clear our reference on destruction
if (parentClass) {
if (JSObject* parentPrototype = parentClass->prototype(exec))
prototype->setPrototype(exec->globalData(), parentPrototype);
Modified: trunk/Source/_javascript_Core/ChangeLog (116577 => 116578)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-10 00:01:49 UTC (rev 116577)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-10 00:04:25 UTC (rev 116578)
@@ -3,6 +3,17 @@
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034
+ Build fix.
+
+ * API/JSClassRef.cpp:
+ (OpaqueJSClass::prototype):
+ - Eeeep, landed bad version of patch!
+
+2012-05-09 Gavin Barraclough <[email protected]>
+
+ GC race condition in OpaqueJSClass::prototype
+ https://bugs.webkit.org/show_bug.cgi?id=86034
+
Reviewed by Filip Pizlo.
The bug here is basically:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
