Title: [116580] trunk/Source/WebCore
- Revision
- 116580
- Author
- [email protected]
- Date
- 2012-05-09 17:14:49 -0700 (Wed, 09 May 2012)
Log Message
[V8] Fix issue where V8BindingPerContextData could keep the context object alive
https://bugs.webkit.org/show_bug.cgi?id=86036
Reviewed by Kentaro Hara.
This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
the layout tests that were introduced since it turns out that
http://trac.webkit.org/changeset/114989 fixes the tests too.
Covered by: http/tests/security/isolatedWorld/context-destroy.html
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116579 => 116580)
--- trunk/Source/WebCore/ChangeLog 2012-05-10 00:12:48 UTC (rev 116579)
+++ trunk/Source/WebCore/ChangeLog 2012-05-10 00:14:49 UTC (rev 116580)
@@ -1,3 +1,19 @@
+2012-05-09 Erik Arvidsson <[email protected]>
+
+ [V8] Fix issue where V8BindingPerContextData could keep the context object alive
+ https://bugs.webkit.org/show_bug.cgi?id=86036
+
+ Reviewed by Kentaro Hara.
+
+ This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
+ the layout tests that were introduced since it turns out that
+ http://trac.webkit.org/changeset/114989 fixes the tests too.
+
+ Covered by: http/tests/security/isolatedWorld/context-destroy.html
+
+ * bindings/v8/V8IsolatedContext.cpp:
+ (WebCore::V8IsolatedContext::destroy):
+
2012-05-09 Anders Carlsson <[email protected]>
Speed up some parts of TileCache drawing
Modified: trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp (116579 => 116580)
--- trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp 2012-05-10 00:12:48 UTC (rev 116579)
+++ trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp 2012-05-10 00:14:49 UTC (rev 116580)
@@ -105,6 +105,7 @@
void V8IsolatedContext::destroy()
{
+ m_perContextData.clear();
m_frame->loader()->client()->willReleaseScriptContext(context(), m_world->id());
m_context->get().MakeWeak(this, &contextWeakReferenceCallback);
m_frame = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
