Title: [116600] trunk/Tools
- Revision
- 116600
- Author
- [email protected]
- Date
- 2012-05-09 20:24:40 -0700 (Wed, 09 May 2012)
Log Message
Improve a warning message for a reftest having an unused expectation file.
https://bugs.webkit.org/show_bug.cgi?id=85975
Reviewed by Adam Barth.
The current warning message is not intuitive. It might be better to update the message
so that it encourage users to remove unused expectation files.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116599 => 116600)
--- trunk/Tools/ChangeLog 2012-05-10 03:08:02 UTC (rev 116599)
+++ trunk/Tools/ChangeLog 2012-05-10 03:24:40 UTC (rev 116600)
@@ -1,3 +1,16 @@
+2012-05-09 Hayato Ito <[email protected]>
+
+ Improve a warning message for a reftest having an unused expectation file.
+ https://bugs.webkit.org/show_bug.cgi?id=85975
+
+ Reviewed by Adam Barth.
+
+ The current warning message is not intuitive. It might be better to update the message
+ so that it encourage users to remove unused expectation files.
+
+ * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+ (SingleTestRunner.__init__):
+
2012-05-09 Ojan Vafai <[email protected]>
Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (116599 => 116600)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-05-10 03:08:02 UTC (rev 116599)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2012-05-10 03:24:40 UTC (rev 116600)
@@ -67,7 +67,7 @@
for suffix in ('.txt', '.png', '.wav'):
expected_filename = self._port.expected_filename(self._test_name, suffix)
if self._filesystem.exists(expected_filename):
- _log.error('%s is both a reftest and has an expected output file %s.',
+ _log.error('%s is a reftest, but has an unused expectation file. Please remove %s.',
self._test_name, expected_filename)
def _expected_driver_output(self):
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
