Title: [116606] trunk/Tools
- Revision
- 116606
- Author
- [email protected]
- Date
- 2012-05-09 21:34:08 -0700 (Wed, 09 May 2012)
Log Message
Don't show partytime if there are non-layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=86056
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (116605 => 116606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-05-10 04:14:01 UTC (rev 116605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-05-10 04:34:08 UTC (rev 116606)
@@ -287,6 +287,10 @@
this._message = message;
this._notification = null;
},
+ hasFailures: function()
+ {
+ return !!this._notification;
+ },
update: function(failuresList)
{
if (Object.keys(failuresList).length == 0) {
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js (116605 => 116606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js 2012-05-10 04:14:01 UTC (rev 116605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js 2012-05-10 04:34:08 UTC (rev 116606)
@@ -73,4 +73,34 @@
});
});
+test("controllers.FailingBuilders", 3, function() {
+ var MockView = base.extends('div', {
+ add: function(node) {
+ this.appendChild(node);
+ }
+ })
+ var view = new MockView();
+ var failingBuilders = new controllers.FailingBuilders(view, 'dummy message');
+ ok(!failingBuilders.hasFailures());
+
+ failingBuilders.update({'DummyBuilder': ['webkit_tests']});
+ ok(failingBuilders.hasFailures());
+
+ equal(view.outerHTML, '<div>' +
+ '<li style="opacity: 0; ">' +
+ '<div class="how"><time class="relative"></time></div>' +
+ '<div class="what">' +
+ '<div class="problem">dummy message:' +
+ '<ul class="effects">' +
+ '<li class="builder"><a class="failing-builder" target="_blank" href="" +
+ '<span class="version">DummyBuilder</span><span class="failures"> webkit_tests</span></a>' +
+ '</li>' +
+ '</ul>' +
+ '</div>' +
+ '<ul class="causes"></ul>' +
+ '</div>' +
+ '</li>' +
+ '</div>')
+});
+
})();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (116605 => 116606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-05-10 04:14:01 UTC (rev 116605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2012-05-10 04:34:08 UTC (rev 116606)
@@ -36,6 +36,14 @@
var g_nonLayoutTestFailureBuilders = null;
+function updatePartyTime()
+{
+ if (!g_unexpectedFailuresController.length() && !g_nonLayoutTestFailureBuilders.hasFailures())
+ $('#onebar').addClass('partytime');
+ else
+ $('#onebar').removeClass('partytime');
+}
+
function update()
{
if (g_revisionHint)
@@ -51,7 +59,10 @@
g_info.add(updating);
- builders.buildersFailingNonLayoutTests(g_nonLayoutTestFailureBuilders.update.bind(g_nonLayoutTestFailureBuilders));
+ builders.buildersFailingNonLayoutTests(function(failuresList) {
+ g_nonLayoutTestFailureBuilders.update(failuresList);
+ updatePartyTime();
+ });
base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
if (g_failuresController)
@@ -63,10 +74,7 @@
updating.update('Analyzing test failures ... ' + ++numberOfTestsAnalyzed + ' tests analyzed.');
g_unexpectedFailuresController.update(failureAnalysis);
}, function() {
- if (!g_unexpectedFailuresController.length())
- $('#onebar').addClass('partytime');
- else
- $('#onebar').removeClass('partytime');
+ updatePartyTime();
g_unexpectedFailuresController.purge();
updating.dismiss();
Modified: trunk/Tools/ChangeLog (116605 => 116606)
--- trunk/Tools/ChangeLog 2012-05-10 04:14:01 UTC (rev 116605)
+++ trunk/Tools/ChangeLog 2012-05-10 04:34:08 UTC (rev 116606)
@@ -1,3 +1,14 @@
+2012-05-09 Ojan Vafai <[email protected]>
+
+ Don't show partytime if there are non-layout test failures.
+ https://bugs.webkit.org/show_bug.cgi?id=86056
+
+ Reviewed by Dimitri Glazkov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+
2012-05-09 Hayato Ito <[email protected]>
Improve a warning message for a reftest having an unused expectation file.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
