[webkit-changes] [116634] trunk/Source/WebKit2

Thu, 10 May 2012 05:38:07 -0700

Title: [116634] trunk/Source/WebKit2
Revision
116634
Author
[email protected]
Date
2012-05-10 05:38:56 -0700 (Thu, 10 May 2012)

Log Message

[Qt] Fix sites with a viewport meta tag when devicePixelRatio isn't explicitely set on the WebView
https://bugs.webkit.org/show_bug.cgi?id=86002

Reviewed by Kenneth Rohde Christiansen.

The preference was recently changed to a double ratio, but was still left under
FOR_EACH_WEBKIT_UINT32_PREFERENCE and was initialized to inf instead of 1.0.
This would cause the viewport constraints to apply a multi-millionaire device
pixel ratio and make the contents invisible.

This moves it with other double preferences under FOR_EACH_WEBKIT_DOUBLE_PREFERENCE.

* Shared/WebPreferencesStore.h:
(WebKit):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (116633 => 116634)


--- trunk/Source/WebKit2/ChangeLog	2012-05-10 12:28:18 UTC (rev 116633)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 12:38:56 UTC (rev 116634)
@@ -1,3 +1,20 @@
+2012-05-10  Jocelyn Turcotte  <[email protected]>
+
+        [Qt] Fix sites with a viewport meta tag when devicePixelRatio isn't explicitely set on the WebView
+        https://bugs.webkit.org/show_bug.cgi?id=86002
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        The preference was recently changed to a double ratio, but was still left under
+        FOR_EACH_WEBKIT_UINT32_PREFERENCE and was initialized to inf instead of 1.0.
+        This would cause the viewport constraints to apply a multi-millionaire device
+        pixel ratio and make the contents invisible.
+
+        This moves it with other double preferences under FOR_EACH_WEBKIT_DOUBLE_PREFERENCE.
+
+        * Shared/WebPreferencesStore.h:
+        (WebKit):
+
 2012-05-10  Kenneth Rohde Christiansen  <[email protected]>
 
         [Qt] Implement fit-to-width behaviour

Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (116633 => 116634)


--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2012-05-10 12:28:18 UTC (rev 116633)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2012-05-10 12:38:56 UTC (rev 116634)
@@ -115,6 +115,7 @@
     \
 
 #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
+    macro(DevicePixelRatio, devicePixelRatio, Double, double, 1.0) \
     macro(PDFScaleFactor, pdfScaleFactor, Double, double, 0) \
     \
 
@@ -131,7 +132,6 @@
     macro(DefaultFontSize, defaultFontSize, UInt32, uint32_t, 16) \
     macro(DefaultFixedFontSize, defaultFixedFontSize, UInt32, uint32_t, 13) \
     macro(LayoutFallbackWidth, layoutFallbackWidth, UInt32, uint32_t, 980) \
-    macro(DevicePixelRatio, devicePixelRatio, Double, double, 1.0) \
     macro(DeviceWidth, deviceWidth, UInt32, uint32_t, 480) \
     macro(DeviceHeight, deviceHeight, UInt32, uint32_t, 854) \
     macro(PDFDisplayMode, pdfDisplayMode, UInt32, uint32_t, 1) \

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to