Diff
Modified: trunk/LayoutTests/ChangeLog (116638 => 116639)
--- trunk/LayoutTests/ChangeLog 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/LayoutTests/ChangeLog 2012-05-10 13:48:47 UTC (rev 116639)
@@ -1,3 +1,13 @@
+2012-05-10 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r116633.
+ http://trac.webkit.org/changeset/116633
+ https://bugs.webkit.org/show_bug.cgi?id=86093
+
+ Breaks EFL tests (Requested by kov on #webkit).
+
+ * platform/efl/Skipped:
+
2012-05-10 Noel Gordon <[email protected]>
[chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
Modified: trunk/LayoutTests/platform/efl/Skipped (116638 => 116639)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-10 13:48:47 UTC (rev 116639)
@@ -249,6 +249,9 @@
editing/selection/selection-background.html
fast/dom/Window/window-onFocus.html
+# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
+fast/events/keypress-insert-tab.html
+
# EFL's LayoutTestController does not implement setUseDashboardCompatibilityMode
fast/canvas/canvas-gradient-addStop-error.html
fast/canvas/fill-stroke-clip-reset-path.html
Modified: trunk/Source/WebKit/efl/ChangeLog (116638 => 116639)
--- trunk/Source/WebKit/efl/ChangeLog 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-05-10 13:48:47 UTC (rev 116639)
@@ -1,3 +1,14 @@
+2012-05-10 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r116633.
+ http://trac.webkit.org/changeset/116633
+ https://bugs.webkit.org/show_bug.cgi?id=86093
+
+ Breaks EFL tests (Requested by kov on #webkit).
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
2012-05-10 Alexander Shalamov <[email protected]>
[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (116638 => 116639)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-05-10 13:48:47 UTC (rev 116639)
@@ -478,15 +478,6 @@
editorClient->setSelectTrailingWhitespaceEnabled(enabled);
}
-void DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles)
-{
- WebCore::Page* page = EWKPrivate::corePage(ewkView);
- if (!page)
- return;
-
- page->setTabKeyCyclesThroughElements(cycles);
-}
-
void DumpRenderTreeSupportEfl::garbageCollectorCollect()
{
WebCore::gcController().garbageCollectNow();
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (116638 => 116639)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-05-10 13:48:47 UTC (rev 116639)
@@ -80,7 +80,6 @@
static void setJavaScriptProfilingEnabled(const Evas_Object* ewkView, bool enabled);
static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
- static void setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles);
static void garbageCollectorCollect();
static void garbageCollectorCollectOnAlternateThread(bool waitUntilDone);
Modified: trunk/Tools/ChangeLog (116638 => 116639)
--- trunk/Tools/ChangeLog 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Tools/ChangeLog 2012-05-10 13:48:47 UTC (rev 116639)
@@ -1,3 +1,18 @@
+2012-05-10 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r116633.
+ http://trac.webkit.org/changeset/116633
+ https://bugs.webkit.org/show_bug.cgi?id=86093
+
+ Breaks EFL tests (Requested by kov on #webkit).
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+ * DumpRenderTree/efl/EventSender.cpp:
+ (keyDownCallback):
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::setTabKeyCyclesThroughElements):
+
2012-05-10 Sudarsana Nagineni <[email protected]>
[EFL] Memory leaks found in EFL DRT
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (116638 => 116639)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-10 13:48:47 UTC (rev 116639)
@@ -264,7 +264,6 @@
DumpRenderTreeSupportEfl::setEditingBehavior(mainView(), defaultEditingBehavior());
DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled(mainView(), false);
DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting(mainView(), false);
- DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(mainView(), true);
}
static CString pathSuitableForTestResult(const char* uriString)
Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (116638 => 116639)
--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-10 13:48:47 UTC (rev 116639)
@@ -497,13 +497,8 @@
static JSValueRef keyDownCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
{
OwnPtr<KeyEventInfo> keyEventInfo = adoptPtr(createKeyEventInfo(context, argumentCount, arguments, exception));
- Evas_Object* mainFrame = browser->mainFrame();
+ sendKeyDown(evas_object_evas_get(browser->mainFrame()), keyEventInfo.get());
- // Focus of the main frame could be lost during the test
- // Therefore, setting focus to the main frame
- evas_object_focus_set(mainFrame, true);
- sendKeyDown(evas_object_evas_get(mainFrame), keyEventInfo.get());
-
return JSValueMakeUndefined(context);
}
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (116638 => 116639)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-05-10 13:48:47 UTC (rev 116639)
@@ -241,9 +241,9 @@
notImplemented();
}
-void LayoutTestController::setTabKeyCyclesThroughElements(bool cycles)
+void LayoutTestController::setTabKeyCyclesThroughElements(bool)
{
- DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(browser->mainView(), cycles);
+ notImplemented();
}
void LayoutTestController::setUseDashboardCompatibilityMode(bool)
