Title: [116662] trunk/Tools
- Revision
- 116662
- Author
- [email protected]
- Date
- 2012-05-10 11:15:04 -0700 (Thu, 10 May 2012)
Log Message
[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
https://bugs.webkit.org/show_bug.cgi?id=86117
Reviewed by Adam Barth.
Simplify the code used to wrap driver calls with jhbuild: we can
just define the 'wrapper' option instead of having to create a
Driver class just for that.
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._port_flag_for_scripts):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116661 => 116662)
--- trunk/Tools/ChangeLog 2012-05-10 18:09:35 UTC (rev 116661)
+++ trunk/Tools/ChangeLog 2012-05-10 18:15:04 UTC (rev 116662)
@@ -1,3 +1,18 @@
+2012-05-10 Raphael Kubo da Costa <[email protected]>
+
+ [EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
+ https://bugs.webkit.org/show_bug.cgi?id=86117
+
+ Reviewed by Adam Barth.
+
+ Simplify the code used to wrap driver calls with jhbuild: we can
+ just define the 'wrapper' option instead of having to create a
+ Driver class just for that.
+
+ * Scripts/webkitpy/layout_tests/port/efl.py:
+ (EflPort.__init__):
+ (EflPort._port_flag_for_scripts):
+
2012-05-10 Sheriff Bot <[email protected]>
Unreviewed, rolling out r116633.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (116661 => 116662)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2012-05-10 18:09:35 UTC (rev 116661)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2012-05-10 18:15:04 UTC (rev 116662)
@@ -32,25 +32,21 @@
import subprocess
from webkitpy.layout_tests.models.test_configuration import TestConfiguration
-from webkitpy.layout_tests.port.webkit import WebKitDriver, WebKitPort
+from webkitpy.layout_tests.port.webkit import WebKitPort
from webkitpy.layout_tests.port.pulseaudio_sanitizer import PulseAudioSanitizer
-class EflDriver(WebKitDriver):
- def cmd_line(self, pixel_tests, per_test_args):
- wrapper_path = self._port.path_from_webkit_base("Tools", "efl", "run-with-jhbuild")
- return [wrapper_path] + WebKitDriver.cmd_line(self, pixel_tests, per_test_args)
-
-
class EflPort(WebKitPort, PulseAudioSanitizer):
port_name = 'efl'
+ def __init__(self, *args, **kwargs):
+ WebKitPort.__init__(self, *args, **kwargs)
+
+ self.set_option_default('wrapper', self.path_from_webkit_base('Tools', 'efl', 'run-with-jhbuild'))
+
def _port_flag_for_scripts(self):
return "--efl"
- def _driver_class(self):
- return EflDriver
-
def setup_test_run(self):
self._unload_pulseaudio_module()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
