Title: [116676] trunk/Tools
- Revision
- 116676
- Author
- [email protected]
- Date
- 2012-05-10 12:28:18 -0700 (Thu, 10 May 2012)
Log Message
[EFL][webkitpy] Do not redefine check_build() in EflPort.
https://bugs.webkit.org/show_bug.cgi?id=86124
Reviewed by Dirk Pranke.
Remove an old FIXME and do not redefine check_build in EflPort;
once build-dumprendertree recognizes --efl, we can use the
check_build implementation in WebKitPort.
* Scripts/build-dumprendertree:
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.check_build):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (116675 => 116676)
--- trunk/Tools/ChangeLog 2012-05-10 19:17:21 UTC (rev 116675)
+++ trunk/Tools/ChangeLog 2012-05-10 19:28:18 UTC (rev 116676)
@@ -1,3 +1,18 @@
+2012-05-10 Raphael Kubo da Costa <[email protected]>
+
+ [EFL][webkitpy] Do not redefine check_build() in EflPort.
+ https://bugs.webkit.org/show_bug.cgi?id=86124
+
+ Reviewed by Dirk Pranke.
+
+ Remove an old FIXME and do not redefine check_build in EflPort;
+ once build-dumprendertree recognizes --efl, we can use the
+ check_build implementation in WebKitPort.
+
+ * Scripts/build-dumprendertree:
+ * Scripts/webkitpy/layout_tests/port/efl.py:
+ (EflPort.check_build):
+
2012-05-10 Tommy Widenflycht <[email protected]>
[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
Modified: trunk/Tools/Scripts/build-dumprendertree (116675 => 116676)
--- trunk/Tools/Scripts/build-dumprendertree 2012-05-10 19:17:21 UTC (rev 116675)
+++ trunk/Tools/Scripts/build-dumprendertree 2012-05-10 19:28:18 UTC (rev 116676)
@@ -46,6 +46,7 @@
--qt Build the Qt port
--wx Build the wxWindows port
--chromium Build the Chromium port
+ --efl Build the EFL port
EOF
GetOptions(
@@ -70,8 +71,8 @@
$result = buildXCodeProject("DumpRenderTree", $clean, XcodeOptions(), @ARGV);
} elsif (isAppleWinWebKit()) {
$result = buildVisualStudioProject("DumpRenderTree.sln", $clean);
-} elsif (isQt() || isGtk() || isWx() || isChromium()) {
- # Qt, Gtk wxWindows, and Chromium build everything in one shot. No need to build anything here.
+} elsif (isQt() || isGtk() || isWx() || isChromium() || isEfl()) {
+ # Qt, Gtk wxWindows, Chromium and EFL build everything in one shot. No need to build anything here.
$result = 0;
} else {
die "Building not defined for this platform!\n";
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (116675 => 116676)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2012-05-10 19:17:21 UTC (rev 116675)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2012-05-10 19:28:18 UTC (rev 116676)
@@ -62,10 +62,6 @@
def _path_to_image_diff(self):
return self._build_path('bin', 'ImageDiff')
- # FIXME: I doubt EFL wants to override this method.
- def check_build(self, needs_http):
- return self._check_driver()
-
def _path_to_webcore_library(self):
static_path = self._build_path('WebCore', 'libwebcore_efl.a')
dyn_path = self._build_path('WebCore', 'libwebcore_efl.so')
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
