- Revision
- 116679
- Author
- [email protected]
- Date
- 2012-05-10 13:10:22 -0700 (Thu, 10 May 2012)
Log Message
[GTK] ENABLE_IFRAME_SEAMLESS support
https://bugs.webkit.org/show_bug.cgi?id=85843
Reviewed by Eric Seidel.
.:
Add a configuration option for enabling the iframe seamless
attribute support, enabling it by default.
* configure.ac:
Source/WebCore:
Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
enabled.
No new tests - all the related tests should now be passing.
* GNUmakefile.am:
Tools:
Add the iframe-seamless option to the options list. This makes it
possible to enable the iframe seamless support through build-webkit
script. Enabled by default for all the ports.
* Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Remove test expectations for the iframe seamless tests. All these
tests should be passing now as the feature is enabled.
* platform/gtk/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/ChangeLog (116678 => 116679)
--- trunk/ChangeLog 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/ChangeLog 2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,15 @@
+2012-05-10 Zan Dobersek <[email protected]>
+
+ [GTK] ENABLE_IFRAME_SEAMLESS support
+ https://bugs.webkit.org/show_bug.cgi?id=85843
+
+ Reviewed by Eric Seidel.
+
+ Add a configuration option for enabling the iframe seamless
+ attribute support, enabling it by default.
+
+ * configure.ac:
+
2012-05-09 Stephen Chenney <[email protected]>
SVG Filters allow invalid elements as children
Modified: trunk/LayoutTests/ChangeLog (116678 => 116679)
--- trunk/LayoutTests/ChangeLog 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/LayoutTests/ChangeLog 2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,15 @@
+2012-05-10 Zan Dobersek <[email protected]>
+
+ [GTK] ENABLE_IFRAME_SEAMLESS support
+ https://bugs.webkit.org/show_bug.cgi?id=85843
+
+ Reviewed by Eric Seidel.
+
+ Remove test expectations for the iframe seamless tests. All these
+ tests should be passing now as the feature is enabled.
+
+ * platform/gtk/test_expectations.txt:
+
2012-05-10 Julien Chaffraix <[email protected]>
Unreviewed Qt gardening.
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (116678 => 116679)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-10 20:10:22 UTC (rev 116679)
@@ -299,8 +299,6 @@
// These tests require subpixel layout to be enabled
BUGWK60318 : fast/sub-pixel = FAIL
-BUGWK85843 : fast/frames/seamless = FAIL
-
//////////////////////////////////////////////////////////////////////////////////////////
// End of Expected failures
//////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/WebCore/ChangeLog (116678 => 116679)
--- trunk/Source/WebCore/ChangeLog 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Source/WebCore/ChangeLog 2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,17 @@
+2012-05-10 Zan Dobersek <[email protected]>
+
+ [GTK] ENABLE_IFRAME_SEAMLESS support
+ https://bugs.webkit.org/show_bug.cgi?id=85843
+
+ Reviewed by Eric Seidel.
+
+ Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
+ enabled.
+
+ No new tests - all the related tests should now be passing.
+
+ * GNUmakefile.am:
+
2012-05-10 Antti Koivisto <[email protected]>
Inline Node::traverseNextNode
Modified: trunk/Source/WebCore/GNUmakefile.am (116678 => 116679)
--- trunk/Source/WebCore/GNUmakefile.am 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Source/WebCore/GNUmakefile.am 2012-05-10 20:10:22 UTC (rev 116679)
@@ -656,6 +656,14 @@
webcore_cppflags += -DENABLE_WEB_TIMING=1
endif # END ENABLE_WEB_TIMING
+# ---
+# HTML iframe seamless attribute support
+# ---
+if ENABLE_IFRAME_SEAMLESS
+FEATURE_DEFINES += ENABLE_IFRAME_SEAMLESS=1
+webcore_cppflags += -DENABLE_IFRAME_SEAMLESS=1
+endif # END ENABLE_IFRAME_SEAMLESS
+
DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h
DerivedSources/WebCore/CSSPropertyNames.h: $(WEBCORE_CSS_PROPERTY_NAMES) $(WebCore)/css/makeprop.pl
$(AM_V_GEN)
Modified: trunk/Tools/ChangeLog (116678 => 116679)
--- trunk/Tools/ChangeLog 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Tools/ChangeLog 2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,16 @@
+2012-05-10 Zan Dobersek <[email protected]>
+
+ [GTK] ENABLE_IFRAME_SEAMLESS support
+ https://bugs.webkit.org/show_bug.cgi?id=85843
+
+ Reviewed by Eric Seidel.
+
+ Add the iframe-seamless option to the options list. This makes it
+ possible to enable the iframe seamless support through build-webkit
+ script. Enabled by default for all the ports.
+
+ * Scripts/webkitperl/FeatureList.pm:
+
2012-05-10 Raphael Kubo da Costa <[email protected]>
[EFL][webkitpy] Do not redefine check_build() in EflPort.
Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (116678 => 116679)
--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2012-05-10 20:10:22 UTC (rev 116679)
@@ -65,6 +65,7 @@
$geolocationSupport,
$highDPICanvasSupport,
$icondatabaseSupport,
+ $iframeSeamlessSupport,
$imageResizerSupport,
$indexedDatabaseSupport,
$inputSpeechSupport,
@@ -191,6 +192,9 @@
{ option => "icon-database", desc => "Toggle Icondatabase support",
define => "ENABLE_ICONDATABASE", default => 1, value => \$icondatabaseSupport },
+ { option => "iframe-seamless", desc => "Toggle iframe seamless attribute support",
+ define => "ENABLE_IFRAME_SEAMLESS", default => 1, value => \$iframeSeamlessSupport },
+
{ option => "indexed-database", desc => "Toggle Indexed Database support",
define => "ENABLE_INDEXED_DATABASE", default => 0, value => \$indexedDatabaseSupport },
Modified: trunk/configure.ac (116678 => 116679)
--- trunk/configure.ac 2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/configure.ac 2012-05-10 20:10:22 UTC (rev 116679)
@@ -734,6 +734,14 @@
[],[enable_sandbox="yes"])
AC_MSG_RESULT([$enable_sandbox])
+# check whether to enable HTML5 iframe seamless attribute support
+AC_MSG_CHECKING([whether to enable HTML5 iframe seamless attribute support])
+AC_ARG_ENABLE(iframe-seamless,
+ AC_HELP_STRING([--enable-iframe-seamless],
+ [enable HTML5 iframe seamless attribute support [default=yes]]),
+ [],[enable_iframe_seamless="yes"])
+AC_MSG_RESULT([$enable_sandbox])
+
# check whether to enable HTML5 audio/video support
AC_MSG_CHECKING([whether to enable HTML5 video support])
AC_ARG_ENABLE(video,
@@ -1396,6 +1404,7 @@
AM_CONDITIONAL([ENABLE_REGISTER_PROTOCOL_HANDLER],[test "$enable_register_protocol_handler" = "yes"])
AM_CONDITIONAL([ENABLE_DEVICE_ORIENTATION],[test "$enable_device_orientation" = "yes"])
AM_CONDITIONAL([ENABLE_MUTATION_OBSERVERS],[test "$enable_mutation_observers" = "yes"])
+AM_CONDITIONAL([ENABLE_IFRAME_SEAMLESS],[test "$enable_iframe_seamless" = "yes"])
# Gtk conditionals
AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"])
@@ -1471,6 +1480,7 @@
HTML5 FileSystem API support : $enable_file_system
Quota API support : $enable_quota
HTML5 sandboxed iframe support : $enable_sandbox
+ HTML5 iframe seamless attribute support : $enable_iframe_seamless
HTML5 video element support : $enable_video
HTML5 track element support : $enable_video_track
Fullscreen API support : $enable_fullscreen_api
