Title: [116691] trunk/Source/WebCore
- Revision
- 116691
- Author
- [email protected]
- Date
- 2012-05-10 14:53:35 -0700 (Thu, 10 May 2012)
Log Message
ASSERT in BidiResolver<Iterator, Run>::commitExplicitEmbedding makes running debug builds annoying
https://bugs.webkit.org/show_bug.cgi?id=86140
Reviewed by Eric Seidel.
The correct fix here is to resolve
https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
this ASSERT is annoying.
* platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116690 => 116691)
--- trunk/Source/WebCore/ChangeLog 2012-05-10 21:52:01 UTC (rev 116690)
+++ trunk/Source/WebCore/ChangeLog 2012-05-10 21:53:35 UTC (rev 116691)
@@ -1,3 +1,17 @@
+2012-05-10 Adam Barth <[email protected]>
+
+ ASSERT in BidiResolver<Iterator, Run>::commitExplicitEmbedding makes running debug builds annoying
+ https://bugs.webkit.org/show_bug.cgi?id=86140
+
+ Reviewed by Eric Seidel.
+
+ The correct fix here is to resolve
+ https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
+ this ASSERT is annoying.
+
+ * platform/text/BidiResolver.h:
+ (WebCore::::commitExplicitEmbedding):
+
2012-05-10 Mark Pilgrim <[email protected]>
[Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly
Modified: trunk/Source/WebCore/platform/text/BidiResolver.h (116690 => 116691)
--- trunk/Source/WebCore/platform/text/BidiResolver.h 2012-05-10 21:52:01 UTC (rev 116690)
+++ trunk/Source/WebCore/platform/text/BidiResolver.h 2012-05-10 21:53:35 UTC (rev 116691)
@@ -403,7 +403,8 @@
bool BidiResolver<Iterator, Run>::commitExplicitEmbedding()
{
// This gets called from bidiFirst when setting up our start position.
- ASSERT(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty());
+ // FIXME: Re-enable this assert once https://bugs.webkit.org/show_bug.cgi?id=76574 is fixed.
+ // ASSERT(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty());
using namespace WTF::Unicode;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
