Title: [116726] trunk
- Revision
- 116726
- Author
- [email protected]
- Date
- 2012-05-10 21:16:04 -0700 (Thu, 10 May 2012)
Log Message
[EFL][DRT] Editor doesn't cancel composition as change of value
https://bugs.webkit.org/show_bug.cgi?id=85122
Patch by Kangil Han <[email protected]> on 2012-05-10
Reviewed by Martin Robinson.
IME composition should be cancelled when the value of input element is changed programmatically.
However, EFL port doesn't cancel as change of value.
Therefore, this patch will fix the bug.
Source/WebKit/efl:
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
LayoutTests:
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (116725 => 116726)
--- trunk/LayoutTests/ChangeLog 2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/LayoutTests/ChangeLog 2012-05-11 04:16:04 UTC (rev 116726)
@@ -1,3 +1,16 @@
+2012-05-10 Kangil Han <[email protected]>
+
+ [EFL][DRT] Editor doesn't cancel composition as change of value
+ https://bugs.webkit.org/show_bug.cgi?id=85122
+
+ Reviewed by Martin Robinson.
+
+ IME composition should be cancelled when the value of input element is changed programmatically.
+ However, EFL port doesn't cancel as change of value.
+ Therefore, this patch will fix the bug.
+
+ * platform/efl/Skipped:
+
2012-05-10 Noel Gordon <[email protected]>
[chromium] Rebaseline compositing/geometry/horizontal-scroll-composited.html after r107389
Modified: trunk/LayoutTests/platform/efl/Skipped (116725 => 116726)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-11 04:16:04 UTC (rev 116726)
@@ -204,10 +204,6 @@
editing/input/password-echo-passnode.html
editing/input/password-echo-passnode2.html
-# EFL's editor doesn't cancel composition as change of value
-# https://bugs.webkit.org/show_bug.cgi?id=85122
-editing/input/setting-input-value-cancel-ime-composition.html
-
# EFL's textarea and textfield doesn't handle whitespace style
# https://bugs.webkit.org/show_bug.cgi?id=85123
fast/forms/cursor-at-editable-content-boundary.html
Modified: trunk/Source/WebKit/efl/ChangeLog (116725 => 116726)
--- trunk/Source/WebKit/efl/ChangeLog 2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-05-11 04:16:04 UTC (rev 116726)
@@ -1,3 +1,17 @@
+2012-05-10 Kangil Han <[email protected]>
+
+ [EFL][DRT] Editor doesn't cancel composition as change of value
+ https://bugs.webkit.org/show_bug.cgi?id=85122
+
+ Reviewed by Martin Robinson.
+
+ IME composition should be cancelled when the value of input element is changed programmatically.
+ However, EFL port doesn't cancel as change of value.
+ Therefore, this patch will fix the bug.
+
+ * WebCoreSupport/EditorClientEfl.cpp:
+ (WebCore::EditorClientEfl::respondToChangedSelection):
+
2012-05-10 Dominik Röttsches <[email protected]>
[EFL][DRT] ewk_view_paint_contents may trigger assertion failure
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (116725 => 116726)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2012-05-11 04:16:04 UTC (rev 116726)
@@ -144,6 +144,15 @@
Evas_Object* webFrame = EWKPrivate::kitFrame(coreFrame);
ewk_frame_editor_client_selection_changed(webFrame);
+
+ if (!coreFrame->editor()->hasComposition() || coreFrame->editor()->ignoreCompositionSelectionChange())
+ return;
+
+ unsigned start;
+ unsigned end;
+
+ if (!coreFrame->editor()->getCompositionSelection(start, end))
+ coreFrame->editor()->cancelComposition();
}
void EditorClientEfl::didEndEditing()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
