Title: [116785] trunk/Source/_javascript_Core
- Revision
- 116785
- Author
- [email protected]
- Date
- 2012-05-11 10:57:17 -0700 (Fri, 11 May 2012)
Log Message
Fix crash seen when running with libgmalloc
<rdar://problem/11435411>
https://bugs.webkit.org/show_bug.cgi?id=86232
Reviewed by Gavin Barraclough.
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadMain):
Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
destructor.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (116784 => 116785)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-11 17:28:21 UTC (rev 116784)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-11 17:57:17 UTC (rev 116785)
@@ -1,3 +1,16 @@
+2012-05-11 Sam Weinig <[email protected]>
+
+ Fix crash seen when running with libgmalloc
+ <rdar://problem/11435411>
+ https://bugs.webkit.org/show_bug.cgi?id=86232
+
+ Reviewed by Gavin Barraclough.
+
+ * heap/MarkStack.cpp:
+ (JSC::MarkStackThreadSharedData::markingThreadMain):
+ Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
+ destructor.
+
2012-05-10 Gavin Barraclough <[email protected]>
Remove op_get_callee
Modified: trunk/Source/_javascript_Core/heap/MarkStack.cpp (116784 => 116785)
--- trunk/Source/_javascript_Core/heap/MarkStack.cpp 2012-05-11 17:28:21 UTC (rev 116784)
+++ trunk/Source/_javascript_Core/heap/MarkStack.cpp 2012-05-11 17:57:17 UTC (rev 116785)
@@ -228,8 +228,10 @@
void MarkStackThreadSharedData::markingThreadMain(SlotVisitor* slotVisitor)
{
WTF::registerGCThread();
- ParallelModeEnabler enabler(*slotVisitor);
- slotVisitor->drainFromShared(SlotVisitor::SlaveDrain);
+ {
+ ParallelModeEnabler enabler(*slotVisitor);
+ slotVisitor->drainFromShared(SlotVisitor::SlaveDrain);
+ }
delete slotVisitor;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
