Title: [116813] trunk/Source/_javascript_Core
- Revision
- 116813
- Author
- [email protected]
- Date
- 2012-05-11 15:37:13 -0700 (Fri, 11 May 2012)
Log Message
JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047
Reviewed by Geoff Garen.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (116812 => 116813)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-11 22:30:34 UTC (rev 116812)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-11 22:37:13 UTC (rev 116813)
@@ -1,3 +1,13 @@
+2012-05-11 Filip Pizlo <[email protected]>
+
+ JIT memory allocator is not returning memory to the OS on Darwin
+ https://bugs.webkit.org/show_bug.cgi?id=86047
+
+ Reviewed by Geoff Garen.
+
+ * jit/ExecutableAllocatorFixedVMPool.cpp:
+ (JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
+
2012-05-11 Geoffrey Garen <[email protected]>
Clarified JSGlobalData (_javascript_ VM) lifetime
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp (116812 => 116813)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp 2012-05-11 22:30:34 UTC (rev 116812)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp 2012-05-11 22:37:13 UTC (rev 116813)
@@ -93,7 +93,10 @@
if (!result)
return;
ASSERT(result == -1);
- ASSERT(errno == EAGAIN);
+ if (errno != EAGAIN) {
+ ASSERT_NOT_REACHED(); // In debug mode, this should be a hard failure.
+ break; // In release mode, we should just ignore the error - not returning memory to the OS is better than crashing, especially since we _will_ be able to reuse the memory internally anyway.
+ }
}
#else
m_reservation.decommit(page, pageSize());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
