Modified: trunk/Source/WebCore/ChangeLog (116851 => 116852)
--- trunk/Source/WebCore/ChangeLog 2012-05-12 12:36:13 UTC (rev 116851)
+++ trunk/Source/WebCore/ChangeLog 2012-05-12 12:52:42 UTC (rev 116852)
@@ -1,3 +1,20 @@
+2012-05-12 Pavel Feldman <[email protected]>
+
+ Web Inspector: make call frame selector pane focusable, allow Up / Down to select current call frame.
+ https://bugs.webkit.org/show_bug.cgi?id=86291
+
+ Reviewed by Yury Semikhatsky.
+
+ This change makes sidebar section focusable, introduces key listeners for Up and Down.
+
+ * inspector/front-end/CallStackSidebarPane.js:
+ (WebInspector.CallStackSidebarPane):
+ (WebInspector.CallStackSidebarPane.prototype.setStatus):
+ (WebInspector.CallStackSidebarPane.prototype._treeKeyDown):
+ * inspector/front-end/UISourceCode.js:
+ * inspector/front-end/scriptsPanel.css:
+ (#scripts-debug-toolbar img):
+
2012-05-12 Ilya Tikhonovsky <[email protected]>
Web Inspector: unreviewed one line fix.
Modified: trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js (116851 => 116852)
--- trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2012-05-12 12:36:13 UTC (rev 116851)
+++ trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2012-05-12 12:52:42 UTC (rev 116852)
@@ -33,6 +33,8 @@
this._model = WebInspector.debuggerModel;
this.bodyElement.addEventListener("contextmenu", this._contextMenu.bind(this), true);
+ this.bodyElement.addEventListener("keydown", this._keyDown.bind(this), true);
+ this.bodyElement.tabIndex = 0;
}
WebInspector.CallStackSidebarPane.prototype = {
@@ -150,6 +152,20 @@
this._statusMessageElement.removeChildren();
this._statusMessageElement.appendChild(status);
}
+ },
+
+ _keyDown: function(event)
+ {
+ if (event.altKey || event.shiftKey || event.metaKey || event.ctrlKey)
+ return;
+
+ if (event.keyIdentifier === "Up") {
+ this._selectPreviousCallFrameOnStack();
+ event.consume();
+ } else if (event.keyIdentifier === "Down") {
+ this._selectNextCallFrameOnStack();
+ event.consume();
+ }
}
}
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (116851 => 116852)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-05-12 12:36:13 UTC (rev 116851)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-05-12 12:52:42 UTC (rev 116852)
@@ -1177,22 +1177,17 @@
}
.placard.selected {
- border-top: 1px solid rgb(145, 160, 192);
- background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(162, 177, 207)), to(rgb(120, 138, 177)));
+ border-top: 1px solid rgb(172, 172, 172);
+ background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(182, 182, 182)), to(rgb(162, 162, 162)));
-webkit-background-origin: padding;
-webkit-background-clip: padding;
}
:focus .placard.selected {
- border-top: 1px solid rgb(68, 128, 200);
- background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(92, 147, 213)), to(rgb(21, 83, 170)));
+ border-top: 1px solid rgb(70, 103, 215);
+ background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(92, 147, 213)), to(rgb(56, 121, 217)));
}
-body.inactive .placard.selected {
- border-top: 1px solid rgb(151, 151, 151);
- background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(180, 180, 180)), to(rgb(138, 138, 138)));
-}
-
.placard .title {
color: black;
font-weight: normal;
