Title: [116926] trunk/Source/_javascript_Core
- Revision
- 116926
- Author
- [email protected]
- Date
- 2012-05-14 00:26:14 -0700 (Mon, 14 May 2012)
Log Message
Introduce PropertyName class
https://bugs.webkit.org/show_bug.cgi?id=86241
Reviewed by Darin Adler.
This patch introduced a couple of small bugs.
* runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
- Returning wrong value for "" - should not convert to 0.
(JSC::PropertyName::PropertyName):
- Remove the ASSERT, it was a little too aspirational.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (116925 => 116926)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-14 06:47:24 UTC (rev 116925)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-14 07:26:14 UTC (rev 116926)
@@ -1,3 +1,18 @@
+2012-05-13 Gavin Barraclough <[email protected]>
+
+ Introduce PropertyName class
+ https://bugs.webkit.org/show_bug.cgi?id=86241
+
+ Reviewed by Darin Adler.
+
+ This patch introduced a couple of small bugs.
+
+ * runtime/PropertyName.h:
+ (JSC::toUInt32FromCharacters):
+ - Returning wrong value for "" - should not convert to 0.
+ (JSC::PropertyName::PropertyName):
+ - Remove the ASSERT, it was a little too aspirational.
+
2012-05-13 Filip Pizlo <[email protected]>
DFG performs incorrect constant folding on double-to-uint32 conversion in
Modified: trunk/Source/_javascript_Core/runtime/PropertyName.h (116925 => 116926)
--- trunk/Source/_javascript_Core/runtime/PropertyName.h 2012-05-14 06:47:24 UTC (rev 116925)
+++ trunk/Source/_javascript_Core/runtime/PropertyName.h 2012-05-14 07:26:14 UTC (rev 116926)
@@ -35,7 +35,7 @@
{
// An empty string is not a number.
if (!length)
- return 0;
+ return UINT_MAX;
// Get the first character, turning it into a digit.
uint32_t value = characters[0] - '0';
@@ -80,7 +80,6 @@
PropertyName(const Identifier& propertyName)
: m_impl(propertyName.impl())
{
- ASSERT(!propertyName.isNull());
}
StringImpl* impl() const { return m_impl; }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
