[webkit-changes] [116972] trunk/LayoutTests

Mon, 14 May 2012 11:17:56 -0700

Title: [116972] trunk/LayoutTests
Revision
116972
Author
[email protected]
Date
2012-05-14 11:18:50 -0700 (Mon, 14 May 2012)

Log Message

Fixup: Two of the touch-adjustment tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <[email protected]> on 2012-05-14
Reviewed by Darin Adler.

One test cases was still not working all platforms.
Change used font to Ahem to have stable layout across platforms.

* touchadjustment/touch-inlines.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (116971 => 116972)


--- trunk/LayoutTests/ChangeLog	2012-05-14 18:17:02 UTC (rev 116971)
+++ trunk/LayoutTests/ChangeLog	2012-05-14 18:18:50 UTC (rev 116972)
@@ -1,3 +1,15 @@
+2012-05-14  Allan Sandfeld Jensen  <[email protected]>
+
+        Fixup: Two of the touch-adjustment tests are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=86218
+
+        Reviewed by Darin Adler.
+
+        One test cases was still not working all platforms.
+        Change used font to Ahem to have stable layout across platforms.
+
+        * touchadjustment/touch-inlines.html:
+
 2012-05-14  Julien Chaffraix  <[email protected]>
 
         Unreviewed rebaseline after r115846.

Modified: trunk/LayoutTests/touchadjustment/touch-inlines.html (116971 => 116972)


--- trunk/LayoutTests/touchadjustment/touch-inlines.html	2012-05-14 18:17:02 UTC (rev 116971)
+++ trunk/LayoutTests/touchadjustment/touch-inlines.html	2012-05-14 18:18:50 UTC (rev 116972)
@@ -1,16 +1,21 @@
 <html>
 <head>
     <script src=""
+    <style>
+        .testcontainer { position: absolute; top: 0px; left: 0px; font: 16px Ahem; line-height: 20px }
+    </style>
 </head>
 <body _onload_="runTests()">
 
-<p style="width: 10em;">
+<div class=testcontainer>
+<p style="width: 22em;">
 <a id="1" href="" link</a><br>
 <a id="2" href="" link breaking lines</a> and <a id="3" href=""
 hola mundo! <a id="4" href="" split up link</a><br>
 hello world <a id="5" href="" link also breaking</a><br>
 hi there <a id="6" href="" link that is breaking multiple lines just for the very fun of it</a><br><br>
 </p>
+</div>
 
 
 <p id='description'></p>
@@ -35,16 +40,16 @@
     {
         debug('Test some direct hits.');
 
-        adjustedNode = testRoundTouch(30, 20, 8)
+        adjustedNode = testRoundTouch(30, 25, 10)
         shouldBeEqualToString('adjustedNode.id', '1');
 
-        adjustedNode = testRoundTouch(30, 60, 8)
+        adjustedNode = testRoundTouch(20, 65, 10)
         shouldBeEqualToString('adjustedNode.id', '2');
 
-        adjustedNode = testRoundTouch(120, 80, 8)
+        adjustedNode = testRoundTouch(220, 85, 10)
         shouldBeEqualToString('adjustedNode.id', '4');
 
-        adjustedNode = testRoundTouch(80, 180, 8)
+        adjustedNode = testRoundTouch(80, 195, 10)
         shouldBeEqualToString('adjustedNode.id', '6');
     }
 
@@ -52,10 +57,12 @@
     {
         debug('Test a few direct misses.');
 
-        adjustedNode = testRoundTouch(56, 60, 8)
+        // Hit 'and' betwen link 2 and 3
+        adjustedNode = testRoundTouch(120, 75, 6)
         shouldBeNull('adjustedNode');
 
-        adjustedNode = testRoundTouch(20, 166, 4)
+        // Hit 'hi there' above and to the left of link 6.
+        adjustedNode = testRoundTouch(72, 166, 6)
         shouldBeNull('adjustedNode');
 
     }
@@ -64,19 +71,19 @@
     {
         debug('Test some in-direct hits.');
 
-        adjustedNode = testRoundTouch(56, 60, 20)
+        adjustedNode = testRoundTouch(50, 60, 20)
         shouldBeEqualToString('adjustedNode.id', '2');
 
-        adjustedNode = testRoundTouch(85, 80, 20)
+        adjustedNode = testRoundTouch(172, 82, 20)
         shouldBeEqualToString('adjustedNode.id', '3');
 
-        adjustedNode = testRoundTouch(120, 66, 30)
+        adjustedNode = testRoundTouch(230, 74, 20)
         shouldBeEqualToString('adjustedNode.id', '4');
 
-        adjustedNode = testRoundTouch(40, 100, 20)
+        adjustedNode = testRoundTouch(30, 100, 20)
         shouldBeEqualToString('adjustedNode.id', '4');
 
-        adjustedNode = testRoundTouch(20, 174, 30)
+        adjustedNode = testRoundTouch(24, 170, 20)
         shouldBeEqualToString('adjustedNode.id', '6');
 
     }

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to