Title: [116995] trunk/Source/WebCore
- Revision
- 116995
- Author
- [email protected]
- Date
- 2012-05-14 13:58:39 -0700 (Mon, 14 May 2012)
Log Message
Avoid logging related to setting shadow-related properties on a transform-only layer
https://bugs.webkit.org/show_bug.cgi?id=86398
Reviewed by Dan Bernstein.
When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
to set filters on the transform layer. We should never have this combination,
because filters force flattening to occur.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (116994 => 116995)
--- trunk/Source/WebCore/ChangeLog 2012-05-14 20:52:05 UTC (rev 116994)
+++ trunk/Source/WebCore/ChangeLog 2012-05-14 20:58:39 UTC (rev 116995)
@@ -1,3 +1,17 @@
+2012-05-14 Simon Fraser <[email protected]>
+
+ Avoid logging related to setting shadow-related properties on a transform-only layer
+ https://bugs.webkit.org/show_bug.cgi?id=86398
+
+ Reviewed by Dan Bernstein.
+
+ When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
+ to set filters on the transform layer. We should never have this combination,
+ because filters force flattening to occur.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::ensureStructuralLayer):
+
2012-05-14 Sheriff Bot <[email protected]>
Unreviewed, rolling out r116983.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (116994 => 116995)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2012-05-14 20:52:05 UTC (rev 116994)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2012-05-14 20:58:39 UTC (rev 116995)
@@ -1412,9 +1412,10 @@
updateTransform();
updateChildrenTransform();
updateBackfaceVisibility();
-
#if ENABLE(CSS_FILTERS)
- updateFilters();
+ // Filters cause flattening, so we should never have a layer for preserve-3d.
+ if (purpose != StructuralLayerForPreserves3D)
+ updateFilters();
#endif
// Set properties of m_layer to their default values, since these are expressed on on the structural layer.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
