Title: [117002] trunk/Tools
- Revision
- 117002
- Author
- [email protected]
- Date
- 2012-05-14 14:25:09 -0700 (Mon, 14 May 2012)
Log Message
Fix regressions in garden-o-matic after r116988.
Unreviewed, build fix.
I had a typo in a field name in checkout.js, and unfortunately
the unittests had the same typo :(.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js (117001 => 117002)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js 2012-05-14 21:19:51 UTC (rev 117001)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js 2012-05-14 21:25:09 UTC (rev 117002)
@@ -103,7 +103,7 @@
{
callIfCheckoutAvailable(function() {
base.callInSequence(function(failureInfo, callback) {
- var suffixes = base.uniquifyArray(base.flattenArray(failureInfo.failureInfoList.map(results.failureTypeToExtensionList))).join(',');
+ var suffixes = base.uniquifyArray(base.flattenArray(failureInfo.failureTypeList.map(results.failureTypeToExtensionList))).join(',');
net.post(config.kLocalServerURL + '/rebaseline?' + $.param({
'builder': failureInfo.builderName,
@@ -118,7 +118,7 @@
var testNameList = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; }));
var suffixes = base.uniquifyArray(base.flattenArray(
failureInfoList.map(function(failureInfo) {
- return base.flattenArray(failureInfo.failureInfoList.map(results.failureTypeToExtensionList))
+ return base.flattenArray(failureInfo.failureTypeList.map(results.failureTypeToExtensionList))
}))).join(',');
base.callInSequence(function(testName, callback) { checkout.optimizeBaselines(testName, suffixes, callback)}, testNameList, callback);
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js (117001 => 117002)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js 2012-05-14 21:19:51 UTC (rev 117001)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js 2012-05-14 21:25:09 UTC (rev 117002)
@@ -97,15 +97,15 @@
checkout.rebaseline([{
'builderName': 'WebKit Linux',
'testName': 'another/test.svg',
- 'failureInfoList': ['IMAGE'],
+ 'failureTypeList': ['IMAGE'],
}, {
'builderName': 'WebKit Mac10.6',
'testName': 'another/test.svg',
- 'failureInfoList': ['IMAGE', 'TEXT', 'IMAGE+TEXT'],
+ 'failureTypeList': ['IMAGE', 'TEXT', 'IMAGE+TEXT'],
}, {
'builderName': 'Webkit Vista',
'testName': 'fast/test.html',
- 'failureInfoList': ['IMAGE+TEXT'],
+ 'failureTypeList': ['IMAGE+TEXT'],
}], function() {
ok(true);
}, function(failureInfo) {
Modified: trunk/Tools/ChangeLog (117001 => 117002)
--- trunk/Tools/ChangeLog 2012-05-14 21:19:51 UTC (rev 117001)
+++ trunk/Tools/ChangeLog 2012-05-14 21:25:09 UTC (rev 117002)
@@ -1,5 +1,18 @@
2012-05-14 Dirk Pranke <[email protected]>
+ Fix regressions in garden-o-matic after r116988.
+
+ Unreviewed, build fix.
+
+ I had a typo in a field name in checkout.js, and unfortunately
+ the unittests had the same typo :(.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
+ (.):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
+
+2012-05-14 Dirk Pranke <[email protected]>
+
garden-o-matic should specify which types of baselines to rebaseline
https://bugs.webkit.org/show_bug.cgi?id=86242
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes