Title: [117062] trunk/LayoutTests
Revision
117062
Author
[email protected]
Date
2012-05-15 06:57:59 -0700 (Tue, 15 May 2012)

Log Message

Making layout testcase: fast/table/empty-section-crash.html result platform independent
https://bugs.webkit.org/show_bug.cgi?id=86352

After modifying the current handling of collapsed borders for
table (https://bugs.webkit.org/show_bug.cgi?id=67877), the expected output for this testcase
changes. Hence, instead of generating new png images and dumprendertext platform specific
output files, have made the output platform independant by making it dumpAsText() only.
Shall be adding a reftest for this along with https://bugs.webkit.org/show_bug.cgi?id=67877.

Patch by Arpita Bahuguna <[email protected]> on 2012-05-15
Reviewed by Antti Koivisto.

* fast/table/empty-section-crash-expected.txt: Added.
Added new expected file.
* fast/table/empty-section-crash.html:
Modified testcase to make it dumpAsText().

* platform/chromium-linux/fast/table/empty-section-crash-expected.png: Removed.
* platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Removed.
* platform/chromium-win/fast/table/empty-section-crash-expected.png: Removed.
* platform/chromium-win/fast/table/empty-section-crash-expected.txt: Removed.
* platform/efl/fast/table/empty-section-crash-expected.png: Removed.
* platform/efl/fast/table/empty-section-crash-expected.txt: Removed.
* platform/gtk/fast/table/empty-section-crash-expected.png: Removed.
* platform/gtk/fast/table/empty-section-crash-expected.txt: Removed.
* platform/mac/fast/table/empty-section-crash-expected.png: Removed.
* platform/mac/fast/table/empty-section-crash-expected.txt: Removed.
* platform/qt/fast/table/empty-section-crash-expected.png: Removed.
* platform/qt/fast/table/empty-section-crash-expected.txt: Removed.
Removed the platform specific expected output files for empty-section-crash.html

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (117061 => 117062)


--- trunk/LayoutTests/ChangeLog	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/ChangeLog	2012-05-15 13:57:59 UTC (rev 117062)
@@ -1,3 +1,35 @@
+2012-05-15  Arpita Bahuguna  <[email protected]>
+
+        Making layout testcase: fast/table/empty-section-crash.html result platform independent
+        https://bugs.webkit.org/show_bug.cgi?id=86352
+        
+        After modifying the current handling of collapsed borders for
+        table (https://bugs.webkit.org/show_bug.cgi?id=67877), the expected output for this testcase
+        changes. Hence, instead of generating new png images and dumprendertext platform specific
+        output files, have made the output platform independant by making it dumpAsText() only.
+        Shall be adding a reftest for this along with https://bugs.webkit.org/show_bug.cgi?id=67877.
+
+        Reviewed by Antti Koivisto.
+
+        * fast/table/empty-section-crash-expected.txt: Added.
+        Added new expected file.
+        * fast/table/empty-section-crash.html:
+        Modified testcase to make it dumpAsText().
+
+        * platform/chromium-linux/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/chromium-win/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/chromium-win/fast/table/empty-section-crash-expected.txt: Removed.
+        * platform/efl/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/efl/fast/table/empty-section-crash-expected.txt: Removed.
+        * platform/gtk/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/gtk/fast/table/empty-section-crash-expected.txt: Removed.
+        * platform/mac/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/mac/fast/table/empty-section-crash-expected.txt: Removed.
+        * platform/qt/fast/table/empty-section-crash-expected.png: Removed.
+        * platform/qt/fast/table/empty-section-crash-expected.txt: Removed.
+        Removed the platform specific expected output files for empty-section-crash.html
+
 2012-05-15  Antti Koivisto  <[email protected]>
 
         Tests added in r117012 (plugins/npruntime/delete-plugin-within-*) failing on Mac bots

Added: trunk/LayoutTests/fast/table/empty-section-crash-expected.txt (0 => 117062)


--- trunk/LayoutTests/fast/table/empty-section-crash-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/table/empty-section-crash-expected.txt	2012-05-15 13:57:59 UTC (rev 117062)
@@ -0,0 +1,5 @@
+Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9009 REGRESSION: ToT crash in WebCore at Zap2it.
+
+No crash means PASS.
+
+

Modified: trunk/LayoutTests/fast/table/empty-section-crash.html (117061 => 117062)


--- trunk/LayoutTests/fast/table/empty-section-crash.html	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/fast/table/empty-section-crash.html	2012-05-15 13:57:59 UTC (rev 117062)
@@ -15,6 +15,7 @@
             if (window.layoutTestController) {
                 layoutTestController.waitUntilDone();
                 setTimeout(finish, 0);
+                layoutTestController.dumpAsText();
             }
         }
     </script>

Deleted: trunk/LayoutTests/platform/chromium-linux/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/chromium-win/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/chromium-win/fast/table/empty-section-crash-expected.txt (117061 => 117062)


--- trunk/LayoutTests/platform/chromium-win/fast/table/empty-section-crash-expected.txt	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/platform/chromium-win/fast/table/empty-section-crash-expected.txt	2012-05-15 13:57:59 UTC (rev 117062)
@@ -1,26 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {P} at (0,0) size 784x20
-        RenderText {#text} at (0,0) size 51x19
-          text run at (0,0) width 51: "Test for "
-        RenderInline {I} at (0,0) size 664x19
-          RenderInline {A} at (0,0) size 350x19 [color=#0000EE]
-            RenderText {#text} at (51,0) size 350x19
-              text run at (51,0) width 350: "http://bugzilla.opendarwin.org/show_bug.cgi?id=9009"
-          RenderText {#text} at (401,0) size 314x19
-            text run at (401,0) width 4: " "
-            text run at (405,0) width 310: "REGRESSION: ToT crash in WebCore at Zap2it"
-        RenderText {#text} at (715,0) size 4x19
-          text run at (715,0) width 4: "."
-      RenderBlock {P} at (0,36) size 784x20
-        RenderText {#text} at (0,0) size 144x19
-          text run at (0,0) width 144: "No crash means PASS."
-layer at (8,-6) size 100x7 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
-  RenderTable {TABLE} at (8,-6) size 100x7 [border: (5px solid #000000) none]
-    RenderTableSection {TBODY} at (0,5) size 100x0
-    RenderTableSection {TBODY} at (0,5) size 100x2
-      RenderTableRow {TR} at (0,0) size 100x2
-        RenderTableCell {TD} at (0,0) size 100x2 [r=0 c=0 rs=1 cs=1]

Deleted: trunk/LayoutTests/platform/efl/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/efl/fast/table/empty-section-crash-expected.txt (117061 => 117062)


--- trunk/LayoutTests/platform/efl/fast/table/empty-section-crash-expected.txt	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/platform/efl/fast/table/empty-section-crash-expected.txt	2012-05-15 13:57:59 UTC (rev 117062)
@@ -1,26 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 53x19
-          text run at (0,0) width 53: "Test for "
-        RenderInline {I} at (0,0) size 663x19
-          RenderInline {A} at (0,0) size 348x19 [color=#0000EE]
-            RenderText {#text} at (53,0) size 348x19
-              text run at (53,0) width 348: "http://bugzilla.opendarwin.org/show_bug.cgi?id=9009"
-          RenderText {#text} at (401,0) size 315x19
-            text run at (401,0) width 4: " "
-            text run at (405,0) width 311: "REGRESSION: ToT crash in WebCore at Zap2it"
-        RenderText {#text} at (716,0) size 4x19
-          text run at (716,0) width 4: "."
-      RenderBlock {P} at (0,34) size 784x18
-        RenderText {#text} at (0,0) size 148x19
-          text run at (0,0) width 148: "No crash means PASS."
-layer at (8,-6) size 100x7 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
-  RenderTable {TABLE} at (8,-6) size 100x7 [border: (5px solid #000000) none]
-    RenderTableSection {TBODY} at (0,5) size 100x0
-    RenderTableSection {TBODY} at (0,5) size 100x2
-      RenderTableRow {TR} at (0,0) size 100x2
-        RenderTableCell {TD} at (0,0) size 100x2 [r=0 c=0 rs=1 cs=1]

Deleted: trunk/LayoutTests/platform/gtk/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/gtk/fast/table/empty-section-crash-expected.txt (117061 => 117062)


--- trunk/LayoutTests/platform/gtk/fast/table/empty-section-crash-expected.txt	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/platform/gtk/fast/table/empty-section-crash-expected.txt	2012-05-15 13:57:59 UTC (rev 117062)
@@ -1,26 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 53x19
-          text run at (0,0) width 53: "Test for "
-        RenderInline {I} at (0,0) size 663x19
-          RenderInline {A} at (0,0) size 348x19 [color=#0000EE]
-            RenderText {#text} at (53,0) size 348x19
-              text run at (53,0) width 348: "http://bugzilla.opendarwin.org/show_bug.cgi?id=9009"
-          RenderText {#text} at (401,0) size 315x19
-            text run at (401,0) width 4: " "
-            text run at (405,0) width 311: "REGRESSION: ToT crash in WebCore at Zap2it"
-        RenderText {#text} at (716,0) size 4x19
-          text run at (716,0) width 4: "."
-      RenderBlock {P} at (0,34) size 784x18
-        RenderText {#text} at (0,0) size 148x19
-          text run at (0,0) width 148: "No crash means PASS."
-layer at (8,-6) size 100x7 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
-  RenderTable {TABLE} at (8,-6) size 100x7 [border: (5px solid #000000) none]
-    RenderTableSection {TBODY} at (0,5) size 100x0
-    RenderTableSection {TBODY} at (0,5) size 100x2
-      RenderTableRow {TR} at (0,0) size 100x2
-        RenderTableCell {TD} at (0,0) size 100x2 [r=0 c=0 rs=1 cs=1]

Deleted: trunk/LayoutTests/platform/mac/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/mac/fast/table/empty-section-crash-expected.txt (117061 => 117062)


--- trunk/LayoutTests/platform/mac/fast/table/empty-section-crash-expected.txt	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/platform/mac/fast/table/empty-section-crash-expected.txt	2012-05-15 13:57:59 UTC (rev 117062)
@@ -1,26 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 53x18
-          text run at (0,0) width 53: "Test for "
-        RenderInline {I} at (0,0) size 663x18
-          RenderInline {A} at (0,0) size 348x18 [color=#0000EE]
-            RenderText {#text} at (53,0) size 348x18
-              text run at (53,0) width 348: "http://bugzilla.opendarwin.org/show_bug.cgi?id=9009"
-          RenderText {#text} at (401,0) size 315x18
-            text run at (401,0) width 4: " "
-            text run at (405,0) width 311: "REGRESSION: ToT crash in WebCore at Zap2it"
-        RenderText {#text} at (716,0) size 4x18
-          text run at (716,0) width 4: "."
-      RenderBlock {P} at (0,34) size 784x18
-        RenderText {#text} at (0,0) size 148x18
-          text run at (0,0) width 148: "No crash means PASS."
-layer at (8,-6) size 100x7 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
-  RenderTable {TABLE} at (8,-6) size 100x7 [border: (5px solid #000000) none]
-    RenderTableSection {TBODY} at (0,5) size 100x0
-    RenderTableSection {TBODY} at (0,5) size 100x2
-      RenderTableRow {TR} at (0,0) size 100x2
-        RenderTableCell {TD} at (0,0) size 100x2 [r=0 c=0 rs=1 cs=1]

Deleted: trunk/LayoutTests/platform/qt/fast/table/empty-section-crash-expected.png


(Binary files differ)

Deleted: trunk/LayoutTests/platform/qt/fast/table/empty-section-crash-expected.txt (117061 => 117062)


--- trunk/LayoutTests/platform/qt/fast/table/empty-section-crash-expected.txt	2012-05-15 13:55:26 UTC (rev 117061)
+++ trunk/LayoutTests/platform/qt/fast/table/empty-section-crash-expected.txt	2012-05-15 13:57:59 UTC (rev 117062)
@@ -1,27 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x576
-      RenderBlock {P} at (0,0) size 784x42
-        RenderText {#text} at (0,0) size 57x21
-          text run at (0,0) width 57: "Test for "
-        RenderInline {I} at (0,0) size 734x42
-          RenderInline {A} at (0,0) size 379x21 [color=#0000EE]
-            RenderText {#text} at (57,0) size 379x21
-              text run at (57,0) width 379: "http://bugzilla.opendarwin.org/show_bug.cgi?id=9009"
-          RenderText {#text} at (436,0) size 734x42
-            text run at (436,0) width 4: " "
-            text run at (440,0) width 294: "REGRESSION: ToT crash in WebCore at"
-            text run at (0,21) width 45: "Zap2it"
-        RenderText {#text} at (45,21) size 4x21
-          text run at (45,21) width 4: "."
-      RenderBlock {P} at (0,58) size 784x21
-        RenderText {#text} at (0,0) size 168x21
-          text run at (0,0) width 168: "No crash means PASS."
-layer at (8,-6) size 100x7 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
-  RenderTable {TABLE} at (8,-6) size 100x7 [border: (5px solid #000000) none]
-    RenderTableSection {TBODY} at (0,5) size 100x0
-    RenderTableSection {TBODY} at (0,5) size 100x2
-      RenderTableRow {TR} at (0,0) size 100x2
-        RenderTableCell {TD} at (0,0) size 100x2 [r=0 c=0 rs=1 cs=1]
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to