Title: [117165] trunk/Source/WebCore
- Revision
- 117165
- Author
- [email protected]
- Date
- 2012-05-15 14:43:10 -0700 (Tue, 15 May 2012)
Log Message
r117147 causes a null-deref crash in DOMImplementation::createDocument()
https://bugs.webkit.org/show_bug.cgi?id=86532
Reviewed by James Robinson.
No new tests, but fixes many crashing tests.
Protect against the possibility of being passed a NULL frame in
DOMImplementation::createDocument().
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117164 => 117165)
--- trunk/Source/WebCore/ChangeLog 2012-05-15 21:39:23 UTC (rev 117164)
+++ trunk/Source/WebCore/ChangeLog 2012-05-15 21:43:10 UTC (rev 117165)
@@ -1,3 +1,18 @@
+2012-05-15 Jer Noble <[email protected]>
+
+ r117147 causes a null-deref crash in DOMImplementation::createDocument()
+ https://bugs.webkit.org/show_bug.cgi?id=86532
+
+ Reviewed by James Robinson.
+
+ No new tests, but fixes many crashing tests.
+
+ Protect against the possibility of being passed a NULL frame in
+ DOMImplementation::createDocument().
+
+ * dom/DOMImplementation.cpp:
+ (WebCore::DOMImplementation::createDocument):
+
2012-05-15 Julien Chaffraix <[email protected]>
Use posZOrderList() / negZOrderList() everywhere to avoid querying dirtied lists
Modified: trunk/Source/WebCore/dom/DOMImplementation.cpp (117164 => 117165)
--- trunk/Source/WebCore/dom/DOMImplementation.cpp 2012-05-15 21:39:23 UTC (rev 117164)
+++ trunk/Source/WebCore/dom/DOMImplementation.cpp 2012-05-15 21:43:10 UTC (rev 117165)
@@ -405,7 +405,7 @@
#if ENABLE(VIDEO)
// Check to see if the type can be played by our MediaPlayer, if so create a MediaDocument
// Key system is not applicable here.
- DOMImplementationSupportsTypeClient client(frame->settings() && frame->settings()->needsSiteSpecificQuirks(), url.host());
+ DOMImplementationSupportsTypeClient client(frame && frame->settings() && frame->settings()->needsSiteSpecificQuirks(), url.host());
if (MediaPlayer::supportsType(ContentType(type), String(), &client))
return MediaDocument::create(frame, url);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
