Title: [117169] trunk/LayoutTests
- Revision
- 117169
- Author
- [email protected]
- Date
- 2012-05-15 15:33:19 -0700 (Tue, 15 May 2012)
Log Message
Result of fast/dom/DOMException/stack-trace.html depends on path (test introduced in r117016)
https://bugs.webkit.org/show_bug.cgi?id=86442
Reviewed by Darin Adler.
This fixes the test to not print the invalid value (which includes file paths) for the JSC fail case.
* fast/dom/DOMException/stack-trace-expected.txt:
* fast/dom/DOMException/stack-trace.html:
* platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:
* platform/gtk/test_expectations.txt:
* platform/qt/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117168 => 117169)
--- trunk/LayoutTests/ChangeLog 2012-05-15 22:05:53 UTC (rev 117168)
+++ trunk/LayoutTests/ChangeLog 2012-05-15 22:33:19 UTC (rev 117169)
@@ -1,3 +1,18 @@
+2012-05-15 Erik Arvidsson <[email protected]>
+
+ Result of fast/dom/DOMException/stack-trace.html depends on path (test introduced in r117016)
+ https://bugs.webkit.org/show_bug.cgi?id=86442
+
+ Reviewed by Darin Adler.
+
+ This fixes the test to not print the invalid value (which includes file paths) for the JSC fail case.
+
+ * fast/dom/DOMException/stack-trace-expected.txt:
+ * fast/dom/DOMException/stack-trace.html:
+ * platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:
+ * platform/gtk/test_expectations.txt:
+ * platform/qt/Skipped:
+
2012-05-15 Brady Eidson <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=86527
Modified: trunk/LayoutTests/fast/dom/DOMException/stack-trace-expected.txt (117168 => 117169)
--- trunk/LayoutTests/fast/dom/DOMException/stack-trace-expected.txt 2012-05-15 22:05:53 UTC (rev 117168)
+++ trunk/LayoutTests/fast/dom/DOMException/stack-trace-expected.txt 2012-05-15 22:33:19 UTC (rev 117169)
@@ -6,10 +6,7 @@
PASS e.name is "HIERARCHY_REQUEST_ERR"
PASS e.message is "HIERARCHY_REQUEST_ERR: DOM Exception 3"
PASS e.code is 3
-FAIL e.stack should be 42 (of type number). Was appendChild@[native code]
-innerFunction@file:///src/WebKit/LayoutTests/fast/dom/DOMException/stack-trace.html:17
-outerFunction@file:///src/WebKit/LayoutTests/fast/dom/DOMException/stack-trace.html:21
-global code@file:///src/WebKit/LayoutTests/fast/dom/DOMException/stack-trace.html:27 (of type string).
+FAIL e.stack === 42 should be true. Was false.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/DOMException/stack-trace.html (117168 => 117169)
--- trunk/LayoutTests/fast/dom/DOMException/stack-trace.html 2012-05-15 22:05:53 UTC (rev 117168)
+++ trunk/LayoutTests/fast/dom/DOMException/stack-trace.html 2012-05-15 22:33:19 UTC (rev 117169)
@@ -40,7 +40,9 @@
shouldBe('e.code', '3');
e.stack = 42;
-shouldBe('e.stack', '42');
+// Don't use shouldBe because the FAIL case still happens on JSC and we don't want the output
+// to depend on the path.
+shouldBeTrue('e.stack === 42');
</script>
<script src=""
Modified: trunk/LayoutTests/platform/chromium/fast/dom/DOMException/stack-trace-expected.txt (117168 => 117169)
--- trunk/LayoutTests/platform/chromium/fast/dom/DOMException/stack-trace-expected.txt 2012-05-15 22:05:53 UTC (rev 117168)
+++ trunk/LayoutTests/platform/chromium/fast/dom/DOMException/stack-trace-expected.txt 2012-05-15 22:33:19 UTC (rev 117169)
@@ -6,7 +6,7 @@
PASS e.name is "HIERARCHY_REQUEST_ERR"
PASS e.message is "HIERARCHY_REQUEST_ERR: DOM Exception 3"
PASS e.code is 3
-PASS e.stack is 42
+PASS e.stack === 42 is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (117168 => 117169)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-15 22:05:53 UTC (rev 117168)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-05-15 22:33:19 UTC (rev 117169)
@@ -1318,8 +1318,6 @@
BUGWK86328 : media/video-controls-toggling.html = FAIL
BUGWK86328 : media/video-controls-rendering-toggle-display-none.html = FAIL
-BUGWK86442 : fast/dom/DOMException/stack-trace.html = FAIL
-
BUGWK86443 : plugins/npruntime/delete-plugin-within-hasProperty-return-false.html = FAIL
BUGWK86443 : plugins/npruntime/delete-plugin-within-hasProperty-return-true.html = FAIL
BUGWK86443 : plugins/npruntime/delete-plugin-within-setProperty.html = FAIL
Modified: trunk/LayoutTests/platform/qt/Skipped (117168 => 117169)
--- trunk/LayoutTests/platform/qt/Skipped 2012-05-15 22:05:53 UTC (rev 117168)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-05-15 22:33:19 UTC (rev 117169)
@@ -2551,10 +2551,6 @@
# Inspector only supports evaluation in content script world with v8, see https://bugs.webkit.org/show_bug.cgi?id=85709
inspector/extensions/extensions-eval-content-script.html
-# Result of fast/dom/DOMException/stack-trace.html depends on path (test introduced in r117016)
-# https://bugs.webkit.org/show_bug.cgi?id=86442
-fast/dom/DOMException/stack-trace.html
-
# [Qt][GTK] New fast/multicol/split-in-top-margin.html fails
# https://bugs.webkit.org/show_bug.cgi?id=86445
fast/multicol/split-in-top-margin.html
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
